feat(stats)!: implement additional metric tags in libdd-trace-stats by duncanpharvey · Pull Request #2170 · DataDog/libdatadog

duncanpharvey · 2026-06-26T19:06:02Z

What does this PR do?

Add additional metric tags to the stats aggregation key. For each configured key, the matching span meta tag is included in the key and populates ClientGroupedStats.additional_metric_tags.
Limit the number of keys for additional_metric_tags to 4, not configurable.
Limit the number of distinct aggregation entries per bucket that carry additional metric tags to 100 by default, configurable via additional_metric_tags_max_entries. Once exceeded, new entries have their tag values masked to tracer_blocked_value.
Limit the maximum length of individual additional_metric_tags values to 200 characters, not configurable. Values exceeding this are replaced with tracer_blocked_value.

Motivation

Allow Serverless Compatibility Layer to send additional metric tags on trace stats. See RFC.
feat: implement additional metric tags for trace stats serverless-components#140 to follow.
https://datadoghq.atlassian.net/browse/SVLS-8787

Additional Notes

Additional metric tags still need to be implemented in libdd-data-pipeline. Omitted from this PR since the goal of this PR is to support additional metric tags tags for Serverless without affecting other teams.

libdatadog/libdd-data-pipeline/src/trace_exporter/stats.rs

Line 146 in 42e3296

vec![],

Implementing additional metric tags instead of span derived primary tags. See previous PR for span derived primary tags - #1815.

How to test the change?

Unit tests
Deploy to Azure Functions with the following environment variables and validate that additional tags appear on trace metrics
- DD_TAGS: custom.primary:val,workload:azure_functions
- DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED: true
- DD_TRACE_STATS_ADDITIONAL_TAGS: custom.primary,workload

datadog-datadog-prod-us1-2 · 2026-06-26T19:06:55Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 98.07%
• Overall Coverage: 74.59% (+0.22%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: a7a73a5 | Docs | Datadog PR Page | Give us feedback!}

github-actions · 2026-06-26T19:08:16Z

📚 Documentation Check Results

⚠️ 3026 documentation warning(s) found

📦 `libdd-data-pipeline` - 1204 warning(s)

📦 `libdd-trace-protobuf` - 227 warning(s)

📦 `libdd-trace-stats` - 864 warning(s)

📦 `libdd-trace-utils` - 731 warning(s)

Updated: 2026-07-06 20:49:50 UTC | Commit: 7c5b40e | missing-docs job results

github-actions · 2026-06-26T19:08:34Z

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

Base Branch: origin/main
PR Branch: origin/duncan-harvey/libdd-trace-stats-additional-metric-tags

Summary by Rule

Rule	Base Branch	PR Branch	Change
unwrap_used	1	1	No change (0%)
Total	1	1	No change (0%)

Annotation Counts by File

File	Base Branch	PR Branch	Change
`libdd-trace-stats/src/stats_exporter.rs`	1	1	No change (0%)

Annotation Stats by Crate

Crate	Base Branch	PR Branch	Change
`clippy-annotation-reporter`	5	5	No change (0%)
`datadog-ffe-ffi`	1	1	No change (0%)
`datadog-ipc`	22	22	No change (0%)
`datadog-live-debugger`	4	4	No change (0%)
`datadog-live-debugger-ffi`	10	10	No change (0%)
`datadog-profiling-replayer`	4	4	No change (0%)
`datadog-sidecar`	45	45	No change (0%)
`libdd-common`	13	13	No change (0%)
`libdd-common-ffi`	12	12	No change (0%)
`libdd-data-pipeline`	6	6	No change (0%)
`libdd-ddsketch`	2	2	No change (0%)
`libdd-dogstatsd-client`	1	1	No change (0%)
`libdd-profiling`	13	13	No change (0%)
`libdd-remote-config`	3	3	No change (0%)
`libdd-telemetry`	20	20	No change (0%)
`libdd-tinybytes`	4	4	No change (0%)
`libdd-trace-normalization`	2	2	No change (0%)
`libdd-trace-obfuscation`	3	3	No change (0%)
`libdd-trace-stats`	1	1	No change (0%)
`libdd-trace-utils`	11	11	No change (0%)
Total	182	182	No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

github-actions · 2026-06-26T19:09:58Z

🔒 Cargo Deny Results

⚠️ 4 issue(s) found, showing only errors (advisories, bans, sources)

📦 `libdd-data-pipeline` - 2 error(s)

Show output

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:218:1
    │
218 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── libdd-common v5.0.0
      │   ├── libdd-capabilities-impl v2.0.0
      │   │   ├── libdd-data-pipeline v6.0.0
      │   │   ├── libdd-shared-runtime v1.0.0
      │   │   │   ├── libdd-data-pipeline v6.0.0 (*)
      │   │   │   ├── libdd-telemetry v5.0.1
      │   │   │   │   ├── libdd-data-pipeline v6.0.0 (*)
      │   │   │   │   └── libdd-trace-stats v5.0.0
      │   │   │   │       └── libdd-data-pipeline v6.0.0 (*)
      │   │   │   └── libdd-trace-stats v5.0.0 (*)
      │   │   ├── libdd-trace-stats v5.0.0 (*)
      │   │   └── libdd-trace-utils v8.0.0
      │   │       ├── libdd-data-pipeline v6.0.0 (*)
      │   │       ├── libdd-trace-obfuscation v4.0.0
      │   │       │   └── libdd-trace-stats v5.0.0 (*)
      │   │       ├── libdd-trace-stats v5.0.0 (*)
      │   │       └── (dev) libdd-trace-utils v8.0.0 (*)
      │   ├── libdd-data-pipeline v6.0.0 (*)
      │   ├── libdd-dogstatsd-client v3.0.0
      │   │   ├── libdd-data-pipeline v6.0.0 (*)
      │   │   └── libdd-trace-stats v5.0.0 (*)
      │   ├── libdd-shared-runtime v1.0.0 (*)
      │   ├── libdd-telemetry v5.0.1 (*)
      │   ├── libdd-trace-obfuscation v4.0.0 (*)
      │   ├── libdd-trace-stats v5.0.0 (*)
      │   └── libdd-trace-utils v8.0.0 (*)
      ├── (dev) libdd-data-pipeline v6.0.0 (*)
      ├── (dev) libdd-ddsketch v1.0.1
      │   ├── libdd-data-pipeline v6.0.0 (*)
      │   ├── libdd-telemetry v5.0.1 (*)
      │   └── libdd-trace-stats v5.0.0 (*)
      ├── (dev) libdd-trace-normalization v2.0.0
      │   ├── libdd-data-pipeline v6.0.0 (*)
      │   └── libdd-trace-utils v8.0.0 (*)
      ├── (dev) libdd-trace-stats v5.0.0 (*)
      ├── libdd-trace-utils v8.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-tinybytes v1.1.1
              ├── libdd-data-pipeline v6.0.0 (*)
              ├── (dev) libdd-tinybytes v1.1.1 (*)
              └── libdd-trace-utils v8.0.0 (*)

error[vulnerability]: Denial of Service via Stack Exhaustion
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:287:1
    │
287 │ time 0.3.41 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0009
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0009
    ├ ## Impact
      
      When user-provided input is provided to any type that parses with the RFC 2822 format, a denial of
      service attack via stack exhaustion is possible. The attack relies on formally deprecated and
      rarely-used features that are part of the RFC 2822 format used in a malicious manner. Ordinary,
      non-malicious input will never encounter this scenario.
      
      ## Patches
      
      A limit to the depth of recursion was added in v0.3.47. From this version, an error will be returned
      rather than exhausting the stack.
      
      ## Workarounds
      
      Limiting the length of user input is the simplest way to avoid stack exhaustion, as the amount of
      the stack consumed would be at most a factor of the length of the input.
    ├ Announcement: https://github.com/time-rs/time/blob/main/CHANGELOG.md#0347-2026-02-05
    ├ Solution: Upgrade to >=0.3.47 (try `cargo update -p time`)
    ├ time v0.3.41
      └── tracing-appender v0.2.3
          └── libdd-log v1.0.0
              └── (dev) libdd-data-pipeline v6.0.0

advisories FAILED, bans ok, sources ok

📦 `libdd-trace-protobuf` - ✅ No issues

📦 `libdd-trace-stats` - 1 error(s)

Show output

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:198:1
    │
198 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── libdd-common v5.0.0
      │   ├── libdd-capabilities-impl v2.0.0
      │   │   ├── libdd-shared-runtime v1.0.0
      │   │   │   ├── libdd-telemetry v5.0.1
      │   │   │   │   └── libdd-trace-stats v5.0.0
      │   │   │   └── libdd-trace-stats v5.0.0 (*)
      │   │   ├── libdd-trace-stats v5.0.0 (*)
      │   │   └── libdd-trace-utils v8.0.0
      │   │       ├── libdd-trace-obfuscation v4.0.0
      │   │       │   └── libdd-trace-stats v5.0.0 (*)
      │   │       ├── libdd-trace-stats v5.0.0 (*)
      │   │       └── (dev) libdd-trace-utils v8.0.0 (*)
      │   ├── libdd-dogstatsd-client v3.0.0
      │   │   └── libdd-trace-stats v5.0.0 (*)
      │   ├── libdd-shared-runtime v1.0.0 (*)
      │   ├── libdd-telemetry v5.0.1 (*)
      │   ├── libdd-trace-obfuscation v4.0.0 (*)
      │   ├── libdd-trace-stats v5.0.0 (*)
      │   └── libdd-trace-utils v8.0.0 (*)
      ├── (dev) libdd-ddsketch v1.0.1
      │   ├── libdd-telemetry v5.0.1 (*)
      │   └── libdd-trace-stats v5.0.0 (*)
      ├── (dev) libdd-trace-normalization v2.0.0
      │   └── libdd-trace-utils v8.0.0 (*)
      ├── (dev) libdd-trace-stats v5.0.0 (*)
      ├── libdd-trace-utils v8.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-tinybytes v1.1.1
              ├── (dev) libdd-tinybytes v1.1.1 (*)
              └── libdd-trace-utils v8.0.0 (*)

advisories FAILED, bans ok, sources ok

📦 `libdd-trace-utils` - 1 error(s)

Show output

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:181:1
    │
181 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── (dev) libdd-common v5.0.0
      │   ├── libdd-capabilities-impl v2.0.0
      │   │   └── libdd-trace-utils v8.0.0
      │   │       └── (dev) libdd-trace-utils v8.0.0 (*)
      │   └── libdd-trace-utils v8.0.0 (*)
      ├── (dev) libdd-trace-normalization v2.0.0
      │   └── libdd-trace-utils v8.0.0 (*)
      ├── libdd-trace-utils v8.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-tinybytes v1.1.1
              ├── (dev) libdd-tinybytes v1.1.1 (*)
              └── libdd-trace-utils v8.0.0 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-07-06 20:51:29 UTC | Commit: 7c5b40e | dependency-check job results

dd-octo-sts · 2026-06-29T15:54:02Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	7.88 MB	7.88 MB	+0% (+48 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	85.91 MB	86.09 MB	+.21% (+188.97 KB) 🔍

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	97.11 MB	97.30 MB	+.19% (+191.63 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.61 MB	10.61 MB	+.04% (+4.80 KB) 🔍

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	25.46 MB	25.51 MB	+.21% (+56.00 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	88.44 KB	88.44 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	184.60 MB	184.87 MB	+.14% (+280.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	946.40 MB	947.21 MB	+.08% (+835.83 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	8.32 MB	8.34 MB	+.18% (+16.00 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	88.44 KB	88.44 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	24.62 MB	24.68 MB	+.25% (+64.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	49.04 MB	49.13 MB	+.19% (+95.99 KB) 🔍

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	22.06 MB	22.11 MB	+.22% (+51.00 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	89.82 KB	89.82 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	188.64 MB	188.94 MB	+.15% (+304.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	935.37 MB	936.19 MB	+.08% (+837.70 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	6.43 MB	6.44 MB	+.18% (+12.50 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	89.82 KB	89.82 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	26.43 MB	26.49 MB	+.23% (+64.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	46.65 MB	46.74 MB	+.19% (+90.84 KB) 🔍

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	76.59 MB	76.75 MB	+.20% (+162.65 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.78 MB	8.79 MB	+.17% (+16.06 KB) 🔍

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	92.11 MB	92.27 MB	+.17% (+164.86 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.69 MB	10.71 MB	+.21% (+23.77 KB) 🔍

# What does this PR do? - Update protobufs to be in sync with datadog-agent * `containerDebug` * `additional_metric_tags` - Update `DATADOG_AGENT_TAG` for protobufs comparison to DataDog/datadog-agent@fdc29d4 # Motivation Out of sync protobufs with datadog-agent. Needed for #2170. # Additional Notes <img width="788" height="301" alt="Screenshot 2026-06-29 at 3 03 21 PM" src="https://github.com/user-attachments/assets/ac605731-2338-4919-a078-1cb31de9b2d0" /> # How to test the change? - Weekly test to compare protobufs to main: https://github.com/DataDog/libdatadog/actions/workflows/weekly-verify-proto-files.yml - Per PR test to compare protobugs to specified commit: https://github.com/DataDog/libdatadog/actions/workflows/verify-proto-files.yml Co-authored-by: duncan.harvey <duncan.harvey@datadoghq.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42e3296aa3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…VALUE_MAX_LEN

# What does this PR do? - Update protobufs to be in sync with datadog-agent * `containerDebug` * `additional_metric_tags` - Update `DATADOG_AGENT_TAG` for protobufs comparison to DataDog/datadog-agent@fdc29d4 # Motivation Out of sync protobufs with datadog-agent. Needed for #2170. # Additional Notes <img width="788" height="301" alt="Screenshot 2026-06-29 at 3 03 21 PM" src="https://github.com/user-attachments/assets/ac605731-2338-4919-a078-1cb31de9b2d0" /> # How to test the change? - Weekly test to compare protobufs to main: https://github.com/DataDog/libdatadog/actions/workflows/weekly-verify-proto-files.yml - Per PR test to compare protobugs to specified commit: https://github.com/DataDog/libdatadog/actions/workflows/verify-proto-files.yml Co-authored-by: duncan.harvey <duncan.harvey@datadoghq.com> Signed-off-by: Taegyun Kim <taegyun.kim@datadoghq.com>

#2170

Eldolfin · 2026-07-13T13:29:48Z

+    /// Return an owned copy of this key with all additional metric tag values replaced by
+    /// `TRACER_BLOCKED_VALUE`. Used when the per-bucket additional-metric-tags cardinality limit
+    /// is exceeded.
+    pub(super) fn into_masked_owned(self) -> OwnedAggregationKey {
+        OwnedAggregationKey {
+            fixed: self.fixed.convert(str::to_owned),
+            peer_tags: self
+                .peer_tags
+                .iter()
+                .map(|(k, v)| (k.to_string(), v.to_string()))
+                .collect(),
+            additional_metric_tags: self
+                .additional_metric_tags
+                .iter()
+                .map(|(k, _)| (k.to_string(), TRACER_BLOCKED_VALUE.to_string()))
+                .collect(),
        }


Per-field cardinality limit for additional tags could go into a follow up PR for consistency with how it's handled for the other fields.

I have an open PR to implement per-field cardinality limits: #2211

So if we merge yours before mine I can implement it in my pr for additional tags too (and I'll make sure to re-use your tests)

github-actions Bot added the data-pipeline label Jun 26, 2026

duncanpharvey mentioned this pull request Jun 26, 2026

feat(stats)!: implement span derived primary tags in libdd-trace-stats #1815

Closed

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch 2 times, most recently from c020593 to 82959f7 Compare June 29, 2026 14:47

github-actions Bot added ci-build mini-agent labels Jun 29, 2026

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from 82959f7 to 9977516 Compare June 29, 2026 15:13

duncanpharvey mentioned this pull request Jun 29, 2026

feat: implement additional metric tags for trace stats DataDog/serverless-components#140

Open

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from fb6b20d to b3d13e5 Compare June 29, 2026 16:02

duncanpharvey mentioned this pull request Jun 30, 2026

chore!: update protobufs to be in sync with datadog-agent #2180

Merged

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from b3d13e5 to def0a56 Compare July 6, 2026 16:47

github-actions Bot removed the ci-build label Jul 6, 2026

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from def0a56 to 42e3296 Compare July 6, 2026 18:13

duncanpharvey marked this pull request as ready for review July 6, 2026 19:51

duncanpharvey requested review from a team as code owners July 6, 2026 19:51

duncanpharvey requested review from a team, apiarian-datadog and lucaspimentel and removed request for a team July 6, 2026 19:52

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread libdd-data-pipeline/src/trace_exporter/stats.rs

Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs Outdated

Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs

implement additional_metric_tags in libdd-trace-stats

60cc354

use character limit rather than byte limit for ADDITIONAL_METRIC_TAG_…

a7a73a5

…VALUE_MAX_LEN

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from 42e3296 to a7a73a5 Compare July 6, 2026 20:47

Eldolfin added a commit that referenced this pull request Jul 10, 2026

fix: link span derived primary tags ticket and pr

7e65d08

#2170

Eldolfin added a commit that referenced this pull request Jul 10, 2026

fix: link span derived primary tags ticket and pr

08652b2

#2170

Eldolfin added a commit that referenced this pull request Jul 10, 2026

fix: link span derived primary tags ticket and pr

edf1e0c

#2170

Eldolfin reviewed Jul 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(stats)!: implement additional metric tags in libdd-trace-stats#2170

feat(stats)!: implement additional metric tags in libdd-trace-stats#2170
duncanpharvey wants to merge 2 commits into
mainfrom
duncan-harvey/libdd-trace-stats-additional-metric-tags

duncanpharvey commented Jun 26, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jun 26, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

Uh oh!

github-actions Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eldolfin Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

duncanpharvey commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jun 26, 2026 • edited by datadog-prod-us1-5 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Documentation Check Results

📦 libdd-data-pipeline - 1204 warning(s)

📦 libdd-trace-protobuf - 227 warning(s)

📦 libdd-trace-stats - 864 warning(s)

📦 libdd-trace-utils - 731 warning(s)

Uh oh!

github-actions Bot commented Jun 26, 2026

Clippy Allow Annotation Report

Summary by Rule

Annotation Counts by File

Annotation Stats by Crate

About This Report

Uh oh!

github-actions Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔒 Cargo Deny Results

📦 libdd-data-pipeline - 2 error(s)

📦 libdd-trace-protobuf - ✅ No issues

📦 libdd-trace-stats - 1 error(s)

📦 libdd-trace-utils - 1 error(s)

Uh oh!

dd-octo-sts Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eldolfin Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

duncanpharvey commented Jun 26, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Jun 26, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

github-actions Bot commented Jun 26, 2026 •

edited

Loading

📦 `libdd-data-pipeline` - 1204 warning(s)

📦 `libdd-trace-protobuf` - 227 warning(s)

📦 `libdd-trace-stats` - 864 warning(s)

📦 `libdd-trace-utils` - 731 warning(s)

github-actions Bot commented Jun 26, 2026 •

edited

Loading

📦 `libdd-data-pipeline` - 2 error(s)

📦 `libdd-trace-protobuf` - ✅ No issues

📦 `libdd-trace-stats` - 1 error(s)

📦 `libdd-trace-utils` - 1 error(s)

dd-octo-sts Bot commented Jun 29, 2026 •

edited

Loading