fix(tracing): address incorrect svc_src/service logic#18833
Draft
emmettbutler wants to merge 101 commits into
Draft
fix(tracing): address incorrect svc_src/service logic#18833emmettbutler wants to merge 101 commits into
emmettbutler wants to merge 101 commits into
Conversation
…vice names on creation and later have service name overridden
fix cherrypy snapshots
mabdinur
reviewed
Jul 21, 2026
| (None, None, "fastapi", "fastapi.request"), | ||
| (None, "v0", "fastapi", "fastapi.request"), | ||
| (None, "v1", DEFAULT_DDTRACE_SUBPROCESS_TEST_SERVICE_NAME, "http.server.request"), | ||
| (None, "v1", "httpx", "http.server.request"), |
Contributor
There was a problem hiding this comment.
This looks like a regression. For v1 the default service should be DEFAULT_DDTRACE_SUBPROCESS_TEST_SERVICE_NAME
…d on finish-time comparison with COMPONENT
Integration test spans with auto-inferred tests.* services now record _dd.svc_src as datadog instead of m, matching the new default service behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
revert asgi test expectation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
those that use
core.context_with_event, which previously was not grabbing the service name from the event instance'sserviceattribute. The affected integrations are:The fix for this issue is the change in
subscribers/_base.py.Some test expectations are changed based on the above functional changes, especially snapshots where
svc_srcandservicewere mismatched. In every case, the updated expectations seem to me to more closely match the service name specification than they did previously.Additional Notes
This change could probably be split apart somewhat, but since many of the snapshot files are affected by multiple fixes, splitting it might be more effort than it's worth.