Skip to content

Place _dd.apm.enabled:0 in every span#4054

Merged
cataphract merged 3 commits into
masterfrom
glopes/_dd.apm.enabled-everywhere
Jul 23, 2026
Merged

Place _dd.apm.enabled:0 in every span#4054
cataphract merged 3 commits into
masterfrom
glopes/_dd.apm.enabled-everywhere

Conversation

@cataphract

Copy link
Copy Markdown
Contributor

Description

As discussed on slack, this is the safest way to ensure _dd.apm.enabled is encountered during processing.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract
cataphract requested a review from a team as a code owner July 23, 2026 11:21
@datadog-official

datadog-official Bot commented Jul 23, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 39 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [7.1]   View in Datadog   GitLab

🧪 2 Tests failed

All test failures are known flaky.

❄️ Known flaky: opendir-003.phpt - opendir() with 'ftps://' stream. from php-src.php-src.ext.standard.tests.streams   View in Datadog
002+ error:0A000415:SSL routines::sslv3 alert certificate expired in /usr/local/src/php/ext/ftp/tests/server.inc on line 121
003+ SSLv23 handshake failed.
004+ 
006+ error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-003.php on line 10
007+ 
002-  in %s on line %d

Not introduced in this PR.

❄️ Known flaky: opendir-004.phpt - opendir() with 'ftps://' stream. from php-src.php-src.ext.standard.tests.streams   View in Datadog
002+ error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-004.php on line 10
003+ 
005+ bool(false)
006+ 
001- resource(%d) of type (stream)
002- string(5) "file1"
003- string(5) "file1"
004- string(3) "fil"
005- string(4) "b0rk"
009+ 
...

Not introduced in this PR.

DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [7.3]   View in Datadog   GitLab

🧪 1 Test failed

All test failures are known flaky.

❄️ Known flaky: opendir() with 'ftps://' stream. from PHP.ext.standard.tests.streams   View in Datadog
002+ error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-004.php on line 10
003+ 
005+ bool(false)
006+ 
001- resource(%d) of type (stream)
002- string(5) "file1"
003- string(5) "file1"
004- string(3) "fil"
005- string(4) "b0rk"
009+ 
...

Not introduced in this PR.

DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [7.4]   View in Datadog   GitLab

🧪 2 Tests failed

All test failures are known flaky.

❄️ Known flaky: ext/standard/tests/streams/opendir-003.phpt (opendir() with 'ftps://' stream.) from PHP.ext.standard.tests.streams   View in Datadog
002+ error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-003.php on line 10
003+ 
005+ error:0A000415:SSL routines::sslv3 alert certificate expired in /usr/local/src/php/ext/ftp/tests/server.inc on line 115
006+ SSLv23 handshake failed.
007+ 
002-  in %s on line %d

Not introduced in this PR.

❄️ Known flaky: ext/standard/tests/streams/opendir-004.phpt (opendir() with 'ftps://' stream.) from PHP.ext.standard.tests.streams   View in Datadog
002+ error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-004.php on line 10
003+ 
005+ error:0A000415:SSL routines::sslv3 alert certificate expired in /usr/local/src/php/ext/ftp/tests/server.inc on line 115
006+ SSLv23 handshake failed.
007+ 
009+ bool(false)
010+ 
001- resource(%d) of type (stream)
002- string(5) "file1"
003- string(5) "file1"
...

Not introduced in this PR.

View all 39 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.65%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6e3fe5d | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 23, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-07-23 23:37:03

Comparing candidate commit 6e3fe5d in PR branch glopes/_dd.apm.enabled-everywhere with baseline commit 262f8b8 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-4.334µs; -3.746µs] or [-3.934%; -3.400%]

@cataphract
cataphract requested a review from a team as a code owner July 23, 2026 14:14
@cataphract
cataphract force-pushed the glopes/_dd.apm.enabled-everywhere branch from d9afcaf to 2a8f6f9 Compare July 23, 2026 15:11
@cataphract
cataphract merged commit f8b39c4 into master Jul 23, 2026
2104 of 2156 checks passed
@cataphract
cataphract deleted the glopes/_dd.apm.enabled-everywhere branch July 23, 2026 22:59
@github-actions github-actions Bot added this to the 1.24.0 milestone Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants