Conversation
bric3
marked this pull request as ready for review
September 30, 2026 14:39
bric3
requested review from
PerfectSlayer and
erikayasuda
and removed request for
a team
September 30, 2026 14:39
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Exclude Java 8 variants from all ARM64 test jobs. Remove the ARM64 latest-dependency Java 8 entry and the resulting unused coverage logic.
Motivation
The newer JVMs contain AArch64 optimizations that might not have been back-ported to the Java 8 distributions we have in had in our test matrix. Moreover depending where the job is scheduled we can land on older hard ware that makes these jobs are way too slow.
It’s noteworthy that AWS explicitly reports that some customers only obtained Graviton's full performance benefit after moving from Java 8 to Java 11. It’s likely possible as well only Corretto 8 (the Amazon Java 8 distribution) got these optimizations, not the other vendors.
In general, here some specific optimizations that may be missing in our chosen Java 8 distributions:
Also, Java 8 lacks broader improvement made in later versions.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue