Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7afe7deec7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| DatadogWrapperHelper.finishSpan(context, response); | ||
| } | ||
| push(responseOutlet, response); |
There was a problem hiding this comment.
When a fused or synchronous handler returns a response within the same actor invocation, actor cleanup has not run yet, so this finishes the server span while its context is still current and then push(responseOutlet, response) executes downstream stages under that finished span. The actor advice restores the checkpoint only when ActorCell.invoke exits, which can cause response-stage work, logging, or nested instrumentation to use an incorrect parent; retain a safe way to detach the request context before the push when it is still current. The parallel Pekko change at lines 114–116 has the same issue.
AGENTS.md reference: AGENTS.md:L43-L46
Useful? React with 👍 / 👎.
![datadog-datadog-prod-us1-2[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
1 participant
What Does This Do
Akka and Pekko HTTP response callbacks can close a request scope after actor cleanup already closed it, sometimes from another thread. Checking whether the request span is active does not establish ownership of the original scope.
Queue request contexts instead of scopes. Actor invocation cleanup remains responsible for scope closure, while response callbacks decorate and finish spans.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]