Skip to content

Fix Axis2 resumed message scope close order - #12699

Open
amarziali wants to merge 1 commit into
masterfrom
andrea.marziali/axis2-scope-order
Open

amarziali wants to merge 1 commit into
masterfrom
andrea.marziali/axis2-scope-order

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Axis2 message resumption activates the child scope before the try-with-resources block closes its resumed parent, causing an out-of-order scope close.

Create the child span under the resumed parent, then activate it after the parent scope closes. This preserves trace parentage and correct scope ordering.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from a team as a code owner September 30, 2026 11:46
@amarziali
amarziali removed the request for review from a team September 30, 2026 11:46
@amarziali amarziali added the type: bug fix Bug fix label Sep 30, 2026
@amarziali amarziali added the inst: others All other instrumentations label Sep 30, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T11:50:08.032526Z d205b73 PR opened
🔒 Security Review ✅ Completed 2026-09-30T11:54:41.558428Z d205b73 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The child span remains created under the resumed parent but is activated only after that parent scope closes, preserving trace parentage while correcting scope order.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d205b73 · @DataDog review to ask questions

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.24% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d205b73 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.96 s [-0.4%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 13.09 s [-2.1%; -0.5%] (maybe better)
startup:petclinic:appsec:Agent 17.09 s 17.08 s [-0.7%; +0.9%] (no difference)
startup:petclinic:iast:Agent 17.01 s 17.12 s [-1.7%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.82 s 16.75 s [-0.7%; +1.6%] (no difference)
startup:petclinic:sca:Agent 17.08 s 16.86 s [+0.3%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 16.24 s 16.30 s [-1.3%; +0.6%] (no difference)

Commit: d205b731 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: others All other instrumentations type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant