Drop noopScope() wrapper caching from OT/OTel TypeConverters#12011
Conversation
The cached noopScopeWrapper only optimized an already-rare path (scope-manager depth-limit overflow); drop the special-casing and the now-unneeded dependency on AgentTracer.noopScope() identity. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
More details
Removing noop scope wrapper caching is safe; the functional contract (scope.span() returns cached noop span wrapper) is preserved. All tests updated to reflect the new behavior correctly. No behavioral regressions detected.
🤖 Datadog Autotest · Commit 5975f1a · What is Autotest? · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 5975f1a | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 3d5c3fb: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
01b5e2c
into
master
What Does This Do
The cached
noopScopeWrapperonly optimized an already-rare path (scope-manager depth-limit overflow); drop the special-casing and the now-unneeded dependency onAgentTracer.noopScope()identity.Motivation
Further step towards being able to completely remove the noopScope() sentinel
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]