Skip to content

Separate release artifact publishing to depend on system test completion#12009

Open
sarahchen6 wants to merge 4 commits into
masterfrom
sarahchen6/add-publish-artifact-step
Open

Separate release artifact publishing to depend on system test completion#12009
sarahchen6 wants to merge 4 commits into
masterfrom
sarahchen6/add-publish-artifact-step

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Separate maven central and github artifact publishing, used during releases, into a separate publish-release-artifacts job. This way, we can configure them to depend on shared-pipeline system-tests to complete before any release artifact is published.

Motivation

In release 1.63.1 where GitLab system-tests failed, Maven and GitHub artifacts were deployed while OCI artifacts were not because only OCI artifacts depended on system-tests success. Ensure that publishing steps occur in line with each other after system-tests succeed.

Additional Notes

Check the effects of the changes in this PR by going to the GitLab pipeline, clicking "Job dependencies" and toggling "Show dependencies" (https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/125758390).

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 20, 2026
@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 14.06 s [-1.7%; +0.0%] (no difference)
startup:insecure-bank:tracing:Agent 13.03 s 13.10 s [-1.2%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 16.91 s 16.62 s [+0.7%; +2.7%] (maybe worse)
startup:petclinic:iast:Agent 16.87 s 16.93 s [-1.1%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.78 s 16.38 s [-2.0%; +6.8%] (no difference)
startup:petclinic:sca:Agent 16.91 s 16.80 s [-0.4%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.05 s 15.49 s [-2.0%; +9.2%] (unstable)

Commit: cee96197 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6
sarahchen6 marked this pull request as ready for review July 20, 2026 19:13
@sarahchen6
sarahchen6 requested review from a team as code owners July 20, 2026 19:13
@sarahchen6
sarahchen6 requested review from dougqh and randomanderson and removed request for a team July 20, 2026 19:13

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

This PR correctly separates release artifact publishing into a dedicated pipeline stage that depends on system test completion. The implementation properly adds system_tests (optional) as a dependency to Maven Central deployment and positions the new publish-release-artifacts stage between shared-pipeline-test and shared-pipeline-publish. Jobs maintain correct ordering within the stage via explicit needs: declarations. Maven/GitHub artifacts will now be blocked if system tests fail, achieving the stated goal from release 1.63.1 where system test failures didn't prevent these deployments.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 2316221 · What is Autotest? · Any feedback? Reach out in #autotest

Base automatically changed from engraver-auto-campaigner/update-one-pipeline-1784565160 to master July 20, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants