Separate release artifact publishing to depend on system test completion#12009
Separate release artifact publishing to depend on system test completion#12009sarahchen6 wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
This PR correctly separates release artifact publishing into a dedicated pipeline stage that depends on system test completion. The implementation properly adds system_tests (optional) as a dependency to Maven Central deployment and positions the new publish-release-artifacts stage between shared-pipeline-test and shared-pipeline-publish. Jobs maintain correct ordering within the stage via explicit needs: declarations. Maven/GitHub artifacts will now be blocked if system tests fail, achieving the stated goal from release 1.63.1 where system test failures didn't prevent these deployments.
📊 Validated against 5 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 2316221 · What is Autotest? · Any feedback? Reach out in #autotest
What Does This Do
Separate maven central and github artifact publishing, used during releases, into a separate
publish-release-artifactsjob. This way, we can configure them to depend on shared-pipeline system-tests to complete before any release artifact is published.Motivation
In release 1.63.1 where GitLab system-tests failed, Maven and GitHub artifacts were deployed while OCI artifacts were not because only OCI artifacts depended on system-tests success. Ensure that publishing steps occur in line with each other after system-tests succeed.
Additional Notes
Check the effects of the changes in this PR by going to the GitLab pipeline, clicking "Job dependencies" and toggling "Show dependencies" (https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/125758390).
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]