Skip Robolectric gradle smoke test on arm64#12005
Skip Robolectric gradle smoke test on arm64#12005gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This seems the issue to follow : robolectric/robolectric#9166 |
There was a problem hiding this comment.
More details
The PR correctly skips Robolectric smoke tests on arm64 by adding a JUnit5 assumption check that mirrors existing patterns in the file. The implementation is minimal, safe (non-arm64 systems unaffected), and addresses the documented arm64-only test failures caused by missing Robolectric native binaries for aarch64.
📊 Validated against 17 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit b4a7362 · What is Autotest? · Any feedback? Reach out in #autotest
…emonSmokeTest.java Applied review notes. Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
DDCI pipeline didn't start (sourcing_failed)... Please retry. DDCI Change Request: |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 5d156b3: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Skips the
testRobolectriccase inGradleDaemonSmokeTestwhen running on arm64 via a JUnit 5Assumptions.assumeFalse(OperatingSystem.architecture().isArm64(), ...)guard.Motivation
The
test_smoke_arm64andtest_ssi_smoke_arm64jobs (shard8/8, JDKs 17/21/semeru17) were the only failures in the pipeline, all on the same test:Robolectric does not ship native runtime binaries for
aarch64, so the embedded Android runner tests cannot run there. The equivalent amd64 jobs pass, confirming this is arm64-only.Additional Notes
Reuses the existing
datadog.environment.OperatingSystemhelper and mirrors the file's existingAssumptionspattern (the test already skips by JDK version).