Skip to content

Skip Robolectric gradle smoke test on arm64#12005

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/skip-robolectric-smoke-test-arm64
Jul 20, 2026
Merged

Skip Robolectric gradle smoke test on arm64#12005
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/skip-robolectric-smoke-test-arm64

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Skips the testRobolectric case in GradleDaemonSmokeTest when running on arm64 via a JUnit 5 Assumptions.assumeFalse(OperatingSystem.architecture().isArm64(), ...) guard.

Motivation

The test_smoke_arm64 and test_ssi_smoke_arm64 jobs (shard 8/8, JDKs 17/21/semeru17) were the only failures in the pipeline, all on the same test:

GradleDaemonSmokeTest > testRobolectric(...) > [1] robolectric-latest FAILED
  └ AndroidJUnit4RunnerTest > test_androidjunit4_runner FAILED
  └ RobolectricRunnerTest  > test_robolectric_runner  FAILED

Robolectric does not ship native runtime binaries for aarch64, so the embedded Android runner tests cannot run there. The equivalent amd64 jobs pass, confirming this is arm64-only.

Additional Notes

Reuses the existing datadog.environment.OperatingSystem helper and mirrors the file's existing Assumptions pattern (the test already skips by JDK version).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix comp: testing Testing tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Jul 20, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jul 20, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review July 20, 2026 14:10
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested a review from a team as a code owner July 20, 2026 14:10
@bric3

bric3 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This seems the issue to follow : robolectric/robolectric#9166

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The PR correctly skips Robolectric smoke tests on arm64 by adding a JUnit5 assumption check that mirrors existing patterns in the file. The implementation is minimal, safe (non-arm64 systems unaffected), and addresses the documented arm64-only test failures caused by missing Robolectric native binaries for aarch64.

Was this helpful? React 👍 or 👎

📊 Validated against 17 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit b4a7362 · What is Autotest? · Any feedback? Reach out in #autotest

Comment thread dd-smoke-tests/gradle/src/test/java/datadog/smoketest/GradleDaemonSmokeTest.java Outdated
…emonSmokeTest.java


Applied review notes.

Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 14.00 s [-0.8%; +0.7%] (no difference)
startup:insecure-bank:tracing:Agent 12.94 s 13.01 s [-1.1%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.39 s 16.71 s [-6.3%; +2.4%] (no difference)
startup:petclinic:iast:Agent 16.87 s 16.40 s [-1.6%; +7.3%] (no difference)
startup:petclinic:profiling:Agent 16.31 s 16.83 s [-4.0%; -2.2%] (significantly better)
startup:petclinic:sca:Agent 16.90 s 16.75 s [-0.2%; +1.9%] (no difference)
startup:petclinic:tracing:Agent 15.94 s 15.95 s [-1.1%; +0.9%] (no difference)

Commit: 31cdea32 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 20, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-20 14:47:42 UTC ℹ️ Start processing command /merge


2026-07-20 14:47:53 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-20 14:53:07 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-20 15:04:12 UTC 🚨 MergeQueue: This merge request is in error because of DDCI

DDCI pipeline didn't start (sourcing_failed)... Please retry.

DDCI Change Request: 5822969384347750899
You can get help from #ci-infra-support

@sarahchen6

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 20, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-20 15:08:34 UTC ℹ️ Start processing command /merge


2026-07-20 15:08:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-20 16:05:00 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 5d156b3:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 20, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-20 17:29:59 UTC ℹ️ Start processing command /merge


2026-07-20 17:30:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-20 18:39:19 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 3cdd938 into master Jul 20, 2026
586 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/skip-robolectric-smoke-test-arm64 branch July 20, 2026 18:39
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants