Skip to content

Declare instrumentation dependencies directly#11986

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/replace-useless-provider-project-path-dependency
Jul 17, 2026
Merged

Declare instrumentation dependencies directly#11986
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/replace-useless-provider-project-path-dependency

Conversation

@bric3

@bric3 bric3 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Replaces provider-wrapped instrumentation project dependencies with direct ProjectDependency declarations.

It also collects the full paths of projects excluded from the aggregate instrumentation JAR in an explicit set.

Motivation

Instrumentation project paths are already known during configuration. Wrapping project(...) in providers.provider adds unnecessary indirection without providing useful laziness.

Declaring project dependencies directly makes the aggregation logic clearer.

Additional Notes

This was introduced when work on removing the afterEvaluate in this project.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 17, 2026
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 17, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 69.73% (+12.46%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 42eb19a | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 13.85 s [+0.5%; +1.9%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.91 s 13.02 s [-1.6%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 16.97 s 16.73 s [+0.3%; +2.7%] (maybe worse)
startup:petclinic:iast:Agent 16.98 s 16.95 s [-0.6%; +1.0%] (no difference)
startup:petclinic:profiling:Agent 16.76 s 16.80 s [-1.3%; +0.8%] (no difference)
startup:petclinic:sca:Agent 16.92 s 16.63 s [+0.7%; +2.9%] (maybe worse)
startup:petclinic:tracing:Agent 16.07 s 16.07 s [-0.8%; +0.8%] (no difference)

Commit: 42eb19ae · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Instrumentation project paths are already known during configuration.
Wrapping `project(...)` in `providers.provider` adds unnecessary
indirection without providing useful laziness.

Declaring project dependencies directly makes the aggregation logic
clearer and keeps compile-only stub projects out of the resulting JAR.

# Conflicts:
#	dd-java-agent/instrumentation/build.gradle
@bric3
bric3 force-pushed the bdu/replace-useless-provider-project-path-dependency branch from 0ca429a to 42eb19a Compare July 17, 2026 18:11
@bric3
bric3 marked this pull request as ready for review July 17, 2026 18:11
@bric3
bric3 requested a review from a team as a code owner July 17, 2026 18:11
@bric3
bric3 requested review from ValentinZakharov and removed request for a team July 17, 2026 18:11

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The PR successfully refactors dependency declaration from lazy provider-wrapped references to direct ProjectDependency calls, aligning with the established pattern already in use elsewhere in the same file (line 29). The change removes unnecessary indirection without altering the dependency graph or build behavior. No regressions identified.

Was this helpful? React 👍 or 👎

📊 Validated against 3 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 42eb19a · What is Autotest? · Any feedback? Reach out in #autotest

@ValentinZakharov ValentinZakharov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bric3

bric3 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/merge -f --reason="Not affected by additional jobs in MQ"

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-17 19:35:25 UTC ℹ️ Start processing command /merge -f --reason="Not affected by additional jobs in MQ"


2026-07-17 19:35:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).


2026-07-17 19:35:39 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: Not affected by additional jobs in MQ

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 33c406b into master Jul 17, 2026
592 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/replace-useless-provider-project-path-dependency branch July 17, 2026 19:35
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants