Declare instrumentation dependencies directly#11986
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 42eb19a | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Instrumentation project paths are already known during configuration. Wrapping `project(...)` in `providers.provider` adds unnecessary indirection without providing useful laziness. Declaring project dependencies directly makes the aggregation logic clearer and keeps compile-only stub projects out of the resulting JAR. # Conflicts: # dd-java-agent/instrumentation/build.gradle
0ca429a to
42eb19a
Compare
There was a problem hiding this comment.
More details
The PR successfully refactors dependency declaration from lazy provider-wrapped references to direct ProjectDependency calls, aligning with the established pattern already in use elsewhere in the same file (line 29). The change removes unnecessary indirection without altering the dependency graph or build behavior. No regressions identified.
📊 Validated against 3 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 42eb19a · What is Autotest? · Any feedback? Reach out in #autotest
|
/merge -f --reason="Not affected by additional jobs in MQ" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: Not affected by additional jobs in MQ |
What Does This Do
Replaces provider-wrapped instrumentation project dependencies with direct
ProjectDependencydeclarations.It also collects the full paths of projects excluded from the aggregate instrumentation JAR in an explicit set.
Motivation
Instrumentation project paths are already known during configuration. Wrapping
project(...)inproviders.provideradds unnecessary indirection without providing useful laziness.Declaring project dependencies directly makes the aggregation logic clearer.
Additional Notes
This was introduced when work on removing the
afterEvaluatein this project.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]