Skip to content

[Tests] Skip MySQL and Npgsql tests on database timeouts#8922

Merged
NachoEchevarria merged 1 commit into
masterfrom
nacho/FixTimeoutFlakinessInTests
Jul 22, 2026
Merged

[Tests] Skip MySQL and Npgsql tests on database timeouts#8922
NachoEchevarria merged 1 commit into
masterfrom
nacho/FixTimeoutFlakinessInTests

Conversation

@NachoEchevarria

@NachoEchevarria NachoEchevarria commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary of changes

Skip the MySqlConnector and Npgsql disabled-integration tests when the database dependency times out.

Reason for change

Avoid transient CI failures caused by database connection timeouts

Implementation details

Test coverage

@github-actions github-actions Bot added the area:tests unit tests, integration tests label Jul 21, 2026
@NachoEchevarria NachoEchevarria changed the title skip on timeout [Tests] Skip MySQL and Npgsql tests on database timeouts Jul 21, 2026
@pr-commenter

pr-commenter Bot commented Jul 21, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-21 16:22:02

Comparing candidate commit cb7f76d in PR branch nacho/FixTimeoutFlakinessInTests with baseline commit 414f94e in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 throughput [-23166.657op/s; -20565.778op/s] or [-6.525%; -5.792%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-5052.283op/s; -4601.273op/s] or [-5.768%; -5.253%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-10054.870op/s; -9514.688op/s] or [-11.922%; -11.282%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-9254.915op/s; -7865.639op/s] or [-9.410%; -7.998%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+317.791ms; +323.743ms] or [+157.699%; +160.653%]
  • 🟥 throughput [-43.113op/s; -39.244op/s] or [-7.757%; -7.061%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+383.389ms; +386.333ms] or [+302.901%; +305.227%]
  • 🟩 throughput [+89.093op/s; +95.955op/s] or [+11.747%; +12.651%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+392.775ms; +395.364ms] or [+347.591%; +349.882%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-15.349ms; -11.180ms] or [-7.168%; -5.222%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-262595.552op/s; -257617.045op/s] or [-26.812%; -26.304%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-26.194ms; -21.345ms] or [-11.681%; -9.519%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-153511.396op/s; -135142.006op/s] or [-22.057%; -19.417%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+9718.712op/s; +12426.554op/s] or [+7.742%; +9.899%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+401414.141op/s; +433969.536op/s] or [+13.385%; +14.470%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-19.297ms; -14.953ms] or [-8.895%; -6.893%]
  • 🟩 throughput [+159504.179op/s; +213385.512op/s] or [+6.331%; +8.470%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.704ms; +300.520ms] or [+149.752%; +150.159%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+299.504ms; +302.660ms] or [+151.040%; +152.632%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+300.331ms; +303.113ms] or [+151.283%; +152.685%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+299.106ms; +301.700ms] or [+146.909%; +148.183%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+290.568ms; +293.827ms] or [+142.048%; +143.641%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+297.269ms; +300.629ms] or [+148.575%; +150.254%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+19.607µs; +43.195µs] or [+6.259%; +13.790%]
  • 🟥 throughput [-405.292op/s; -206.761op/s] or [-12.634%; -6.445%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.516ms; +300.292ms] or [+149.489%; +149.877%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+335.931ms; +398.817ms] or [+365.002%; +433.331%]
  • 🟩 throughput [+832.378op/s; +1032.246op/s] or [+6.840%; +8.482%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+196.242ms; +261.329ms] or [+149.005%; +198.424%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+269.763ms; +309.420ms] or [+124.034%; +142.268%]
  • 🟥 throughput [-499.477op/s; -459.468op/s] or [-45.258%; -41.632%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+202.913ms; +336.203ms] or [+86.473%; +143.275%]
  • 🟥 throughput [-671.491op/s; -587.962op/s] or [-44.789%; -39.217%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+332.334ms; +342.609ms] or [+198.774%; +204.920%]
  • 🟥 throughput [-381.929op/s; -345.913op/s] or [-26.593%; -24.085%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-192.568µs; -140.537µs] or [-9.755%; -7.119%]
  • 🟩 throughput [+41.001op/s; +54.885op/s] or [+8.094%; +10.835%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+300.537ms; +302.821ms] or [+151.345%; +152.495%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+302.913ms; +303.966ms] or [+151.790%; +152.318%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+303.436ms; +307.114ms] or [+152.433%; +154.281%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+302.417ms; +303.815ms] or [+151.864%; +152.566%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.359ms; +299.765ms] or [+147.525%; +148.220%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+302.647ms; +306.708ms] or [+153.395%; +155.453%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+304.665ms; +307.336ms] or [+152.914%; +154.255%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+302.255ms; +304.738ms] or [+150.646%; +151.884%]
  • 🟩 throughput [+39251.672op/s; +51040.970op/s] or [+7.794%; +10.135%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+300.224ms; +302.684ms] or [+149.359%; +150.583%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-17.109ms; -13.448ms] or [-7.956%; -6.253%]
  • 🟩 throughput [+19708.361op/s; +27152.880op/s] or [+5.407%; +7.449%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+15.509µs; +60.969µs] or [+3.831%; +15.060%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.675KB; -19.654KB] or [-7.177%; -7.169%]
  • unstable execution_time [-52.544µs; +2.211µs] or [-10.385%; +0.437%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-54.942µs; +6.701µs] or [-9.521%; +1.161%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+6.344µs; +10.503µs] or [+14.994%; +24.826%]
  • 🟥 throughput [-4827.327op/s; -3023.520op/s] or [-20.322%; -12.728%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.053µs; -6.485µs] or [-21.802%; -10.062%]
  • unstable throughput [+1569.560op/s; +3241.867op/s] or [+9.630%; +19.890%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.802ms; +304.086ms] or [+153.053%; +153.702%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.003ms; +303.659ms] or [+153.209%; +154.562%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.585ms; +301.540ms] or [+149.979%; +150.958%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+36223.705op/s; +39941.447op/s] or [+6.856%; +7.560%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+298.348ms; +300.195ms] or [+148.700%; +149.620%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.397ms; +305.904ms] or [+152.352%; +153.611%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+304.471ms; +307.001ms] or [+154.408%; +155.691%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.197ms; +300.952ms] or [+149.740%; +150.117%]
  • 🟩 throughput [+61041516.497op/s; +61358677.906op/s] or [+44.454%; +44.685%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+421.256ms; +425.543ms] or [+523.907%; +529.239%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.139ms; +300.245ms] or [+149.204%; +149.755%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+97944.342op/s; +107049.384op/s] or [+9.145%; +9.995%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+46421.295op/s; +67750.252op/s] or [+5.373%; +7.842%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+81209.311op/s; +89047.277op/s] or [+8.065%; +8.844%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+57428.594op/s; +62417.234op/s] or [+10.428%; +11.334%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+25374.721op/s; +35464.669op/s] or [+5.680%; +7.938%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+49612.677op/s; +68638.407op/s] or [+5.543%; +7.669%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@NachoEchevarria
NachoEchevarria marked this pull request as ready for review July 22, 2026 10:09
@NachoEchevarria
NachoEchevarria requested review from a team as code owners July 22, 2026 10:09
@NachoEchevarria
NachoEchevarria requested review from vandonr and removed request for a team July 22, 2026 10:09
andrewlock
andrewlock approved these changes Jul 22, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks! Are there any other database tests you think we should apply this to as well?

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8922) and master.

⚠️ Potential regressions detected

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Bailout
duration216.75 ± (216.18 - 217.99) ms235.66 ± (234.05 - 236.57) ms+8.7%❌⬆️
Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.06 ± (72.11 - 72.69) ms74.49 ± (74.27 - 74.87) ms+3.4%✅⬆️
.NET Framework 4.8 - Bailout
duration75.27 ± (75.27 - 75.61) ms76.59 ± (76.60 - 77.04) ms+1.8%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1084.47 ± (1083.77 - 1090.30) ms1088.06 ± (1087.09 - 1093.13) ms+0.3%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.23 ± (22.19 - 22.28) ms22.41 ± (22.36 - 22.46) ms+0.8%✅⬆️
process.time_to_main_ms82.51 ± (82.27 - 82.76) ms84.01 ± (83.69 - 84.33) ms+1.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed11.01 ± (11.00 - 11.01) MB10.99 ± (10.99 - 11.00) MB-0.1%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.93 ± (21.91 - 21.95) ms22.19 ± (22.16 - 22.21) ms+1.2%✅⬆️
process.time_to_main_ms82.84 ± (82.64 - 83.05) ms82.78 ± (82.62 - 82.93) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed11.05 ± (11.04 - 11.05) MB11.03 ± (11.03 - 11.04) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms209.86 ± (209.07 - 210.64) ms210.89 ± (210.16 - 211.62) ms+0.5%✅⬆️
process.time_to_main_ms539.56 ± (538.28 - 540.84) ms540.28 ± (539.12 - 541.45) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.50 ± (49.47 - 49.53) MB49.51 ± (49.48 - 49.54) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms21.20 ± (21.15 - 21.25) ms20.98 ± (20.95 - 21.01) ms-1.0%✅
process.time_to_main_ms74.21 ± (73.92 - 74.49) ms71.42 ± (71.27 - 71.58) ms-3.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.75 ± (10.75 - 10.75) MB10.75 ± (10.74 - 10.75) MB-0.0%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.76 ± (20.73 - 20.78) ms20.90 ± (20.87 - 20.93) ms+0.7%✅⬆️
process.time_to_main_ms72.32 ± (72.16 - 72.47) ms72.61 ± (72.47 - 72.75) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.86 ± (10.86 - 10.87) MB10.85 ± (10.85 - 10.85) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms372.53 ± (370.72 - 374.35) ms371.36 ± (369.33 - 373.39) ms-0.3%✅
process.time_to_main_ms543.23 ± (541.95 - 544.50) ms547.91 ± (546.62 - 549.20) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.56 ± (50.54 - 50.58) MB50.53 ± (50.51 - 50.55) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.10 ± (19.07 - 19.12) ms19.45 ± (19.39 - 19.51) ms+1.9%✅⬆️
process.time_to_main_ms70.32 ± (70.16 - 70.48) ms74.65 ± (74.28 - 75.02) ms+6.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.75 ± (7.75 - 7.75) MB7.77 ± (7.77 - 7.78) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.32 ± (19.28 - 19.37) ms19.19 ± (19.16 - 19.22) ms-0.7%✅
process.time_to_main_ms74.77 ± (74.50 - 75.04) ms72.68 ± (72.51 - 72.85) ms-2.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.81 ± (7.81 - 7.82) MB7.83 ± (7.82 - 7.83) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms298.39 ± (296.29 - 300.50) ms298.28 ± (295.67 - 300.89) ms-0.0%✅
process.time_to_main_ms491.24 ± (490.26 - 492.23) ms494.71 ± (493.46 - 495.96) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed37.96 ± (37.93 - 37.98) MB38.04 ± (38.02 - 38.06) MB+0.2%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.1%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration208.70 ± (208.98 - 210.34) ms218.14 ± (218.53 - 220.38) ms+4.5%✅⬆️
.NET Framework 4.8 - Bailout
duration216.75 ± (216.18 - 217.99) ms235.66 ± (234.05 - 236.57) ms+8.7%❌⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1242.60 ± (1244.23 - 1252.82) ms1272.85 ± (1273.06 - 1282.31) ms+2.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms200.51 ± (199.90 - 201.11) ms225.95 ± (224.63 - 227.27) ms+12.7%✅⬆️
process.time_to_main_ms86.92 ± (86.66 - 87.17) ms93.93 ± (93.46 - 94.40) ms+8.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (16.09 - 16.12) MB16.01 ± (15.99 - 16.02) MB-0.6%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.8%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms202.61 ± (201.85 - 203.36) ms216.51 ± (215.32 - 217.70) ms+6.9%✅⬆️
process.time_to_main_ms89.18 ± (88.93 - 89.43) ms92.79 ± (92.41 - 93.17) ms+4.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (16.09 - 16.12) MB16.10 ± (16.08 - 16.11) MB-0.1%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.8%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms393.13 ± (391.74 - 394.52) ms411.85 ± (410.26 - 413.44) ms+4.8%✅⬆️
process.time_to_main_ms557.31 ± (555.88 - 558.75) ms575.98 ± (574.56 - 577.41) ms+3.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed59.48 ± (59.31 - 59.66) MB59.96 ± (59.91 - 60.00) MB+0.8%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.8%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms209.50 ± (208.63 - 210.37) ms224.83 ± (223.32 - 226.33) ms+7.3%✅⬆️
process.time_to_main_ms76.74 ± (76.51 - 76.97) ms80.30 ± (79.95 - 80.65) ms+4.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.40 ± (16.38 - 16.41) MB16.30 ± (16.28 - 16.32) MB-0.6%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 20)+0.6%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms210.97 ± (210.06 - 211.88) ms238.65 ± (237.37 - 239.93) ms+13.1%✅⬆️
process.time_to_main_ms78.42 ± (78.18 - 78.65) ms83.30 ± (82.90 - 83.69) ms+6.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.47 ± (16.45 - 16.48) MB16.31 ± (16.30 - 16.33) MB-0.9%✅
runtime.dotnet.threads.count20 ± (20 - 21)21 ± (20 - 21)+0.1%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms583.41 ± (580.37 - 586.45) ms585.37 ± (582.10 - 588.64) ms+0.3%✅⬆️
process.time_to_main_ms568.02 ± (566.86 - 569.19) ms579.96 ± (578.67 - 581.25) ms+2.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.60 ± (61.51 - 61.68) MB61.72 ± (61.62 - 61.81) MB+0.2%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms206.02 ± (205.33 - 206.71) ms219.29 ± (217.82 - 220.76) ms+6.4%✅⬆️
process.time_to_main_ms75.64 ± (75.45 - 75.84) ms78.64 ± (78.26 - 79.02) ms+4.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.73 ± (11.72 - 11.75) MB11.67 ± (11.65 - 11.69) MB-0.6%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms205.57 ± (204.85 - 206.30) ms221.94 ± (220.76 - 223.12) ms+8.0%✅⬆️
process.time_to_main_ms76.93 ± (76.74 - 77.12) ms79.79 ± (79.48 - 80.10) ms+3.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.76 ± (11.75 - 11.78) MB11.69 ± (11.67 - 11.70) MB-0.6%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.2%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms530.32 ± (523.80 - 536.85) ms596.04 ± (589.77 - 602.31) ms+12.4%✅⬆️
process.time_to_main_ms520.24 ± (519.18 - 521.29) ms526.73 ± (525.64 - 527.82) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed51.51 ± (51.44 - 51.58) MB52.11 ± (52.02 - 52.20) MB+1.2%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+1.0%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (75ms)  : 70, 79
    master - mean (72ms)  : 68, 77

    section Bailout
    This PR (8922) - mean (77ms)  : 74, 80
    master - mean (75ms)  : 74, 77

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (1,090ms)  : 1047, 1133
    master - mean (1,087ms)  : 1039, 1135
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (114ms)  : 106, 121
    master - mean (112ms)  : 106, 117

    section Bailout
    This PR (8922) - mean (111ms)  : 110, 113
    master - mean (111ms)  : 109, 113

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (789ms)  : 767, 811
    master - mean (787ms)  : 760, 815
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (98ms)  : 96, 101
    master - mean (102ms)  : 97, 108

    section Bailout
    This PR (8922) - mean (99ms)  : 98, 101
    master - mean (99ms)  : 96, 102

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (952ms)  : 913, 990
    master - mean (945ms)  : 912, 978
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (103ms)  : 97, 108
    master - mean (96ms)  : 92, 100

    section Bailout
    This PR (8922) - mean (100ms)  : 95, 105
    master - mean (102ms)  : 97, 107

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (822ms)  : 782, 863
    master - mean (820ms)  : 780, 860
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (219ms)  : 206, 233
    master - mean (210ms)  : 200, 219

    section Bailout
    This PR (8922) - mean (235ms)  : crit, 216, 255
    master - mean (217ms)  : 204, 231

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (1,278ms)  : 1207, 1348
    master - mean (1,249ms)  : 1185, 1312
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (332ms)  : 314, 349
    master - mean (298ms)  : 285, 311

    section Bailout
    This PR (8922) - mean (320ms)  : 298, 341
    master - mean (302ms)  : 286, 319

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (1,028ms)  : 980, 1075
    master - mean (993ms)  : 962, 1023
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (315ms)  : 286, 343
    master - mean (296ms)  : 280, 311

    section Bailout
    This PR (8922) - mean (332ms)  : crit, 310, 354
    master - mean (299ms)  : 280, 318

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (1,199ms)  : 1145, 1253
    master - mean (1,185ms)  : 1135, 1235
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8922) - mean (310ms)  : 284, 336
    master - mean (294ms)  : 282, 305

    section Bailout
    This PR (8922) - mean (313ms)  : crit, 290, 337
    master - mean (294ms)  : 280, 308

    section CallTarget+Inlining+NGEN
    This PR (8922) - mean (1,156ms)  : crit, 1064, 1248
    master - mean (1,088ms)  : 983, 1193
Loading

@NachoEchevarria

NachoEchevarria commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Good call, thanks! Are there any other database tests you think we should apply this to as well?

I just applied the changes to tests that failed. Potentially, we could do it also for:
SystemDataSqlClientTests, NpgsqlCommandTests, MySqlCommandTests, MySqlConnectorTests
We could probably do it even if the tests have not failed recently. WDYT?

@andrewlock

andrewlock commented Jul 22, 2026

Copy link
Copy Markdown
Member

We could probably do it even if the tests have not failed recently. WDYT?

I don't have a strong feeling either way - if they haven't flaked yet, we can just bear it in mind I guess 🙂

@NachoEchevarria
NachoEchevarria merged commit d2eb49f into master Jul 22, 2026
140 checks passed
@NachoEchevarria
NachoEchevarria deleted the nacho/FixTimeoutFlakinessInTests branch July 22, 2026 16:05
@github-actions github-actions Bot added this to the vNext-v3 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes
@andrewlock andrewlock andrewlock approved these changes
@vandonr vandonr Awaiting requested review from vandonr vandonr is a code owner automatically assigned from DataDog/apm-idm-dotnet

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

3 participants

@NachoEchevarria @andrewlock @bouwkast