Move TestOptimizationFeatureTests to TracerInstanceTestCollection#8880
Open
bouwkast wants to merge 2 commits into
Open
Move TestOptimizationFeatureTests to TracerInstanceTestCollection#8880bouwkast wants to merge 2 commits into
bouwkast wants to merge 2 commits into
Conversation
bouwkast
added
area:tests
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8880) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (73ms) : 69, 76
master - mean (70ms) : 68, 72
section Bailout
This PR (8880) - mean (76ms) : 73, 79
master - mean (76ms) : 71, 81
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,083ms) : 1040, 1126
master - mean (1,089ms) : 1041, 1137
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (113ms) : 106, 120
master - mean (109ms) : 107, 112
section Bailout
This PR (8880) - mean (110ms) : 107, 113
master - mean (115ms) : 109, 121
section CallTarget+Inlining+NGEN
This PR (8880) - mean (781ms) : 757, 805
master - mean (776ms) : 756, 796
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (96ms) : 93, 99
master - mean (101ms) : 95, 106
section Bailout
This PR (8880) - mean (100ms) : 94, 105
master - mean (98ms) : 95, 101
section CallTarget+Inlining+NGEN
This PR (8880) - mean (928ms) : 892, 965
master - mean (937ms) : 901, 973
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (97ms) : 91, 103
master - mean (95ms) : 91, 98
section Bailout
This PR (8880) - mean (95ms) : 94, 97
master - mean (100ms) : 96, 105
section CallTarget+Inlining+NGEN
This PR (8880) - mean (812ms) : 775, 849
master - mean (810ms) : 776, 845
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (204ms) : 196, 211
master - mean (204ms) : 200, 208
section Bailout
This PR (8880) - mean (210ms) : 204, 215
master - mean (208ms) : 204, 212
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,232ms) : 1171, 1292
master - mean (1,217ms) : 1168, 1266
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (293ms) : 282, 304
master - mean (293ms) : 286, 300
section Bailout
This PR (8880) - mean (295ms) : 285, 304
master - mean (294ms) : 288, 300
section CallTarget+Inlining+NGEN
This PR (8880) - mean (982ms) : 959, 1005
master - mean (980ms) : 958, 1002
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (288ms) : 280, 296
master - mean (285ms) : 279, 291
section Bailout
This PR (8880) - mean (288ms) : 281, 295
master - mean (286ms) : 282, 291
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,171ms) : 1132, 1209
master - mean (1,177ms) : 1143, 1211
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (281ms) : 274, 289
master - mean (281ms) : 273, 288
section Bailout
This PR (8880) - mean (285ms) : 280, 290
master - mean (281ms) : 275, 287
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,053ms) : 1006, 1100
master - mean (1,046ms) : 981, 1112
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-07-21 14:23:08 Comparing candidate commit debf14c in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.
|
bouwkast
marked this pull request as ready for review
July 9, 2026 12:28
bouwkast
force-pushed
the
steven/coverage-ipc-unit-test-flake
branch
from
July 9, 2026 16:44
d777ed0 to
1a77b0d
Compare
andrewlock
approved these changes
Jul 20, 2026
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
Thanks 👍 I hate global state 😢
bouwkast
force-pushed
the
steven/coverage-ipc-unit-test-flake
branch
from
July 21, 2026 13:31
1a77b0d to
debf14c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This puts TestOptimizationFeatureTests in the same non-parallel collection as TestSessionCoverageTests, so it can no longer null the CIVisibilityItrCoverageBackfillRunFolder mid-test and cause flake in the tests.
Reason for change
Needs to run synchronously as they mutate the
TestOptimization.Instance.Tests flaked for
CloseDoesNotPublishPersistedCoverageWhenPersistedCoverageIpcSnapshotIsIncompletewithDid not expect a value, but found 80.0.which was caused by other tests.Implementation details
Moved the collection to
[Collection(nameof(TracerInstanceTestCollection))]Test coverage
Other details
#incident-57303