Fix cmake install missing http_endpoint_calculation_mode.h#341
Open
spottsdd wants to merge 1 commit into
Open
Conversation
tracer_config.h (a public header) includes http_endpoint_calculation_mode.h, but it was missing from the public_headers FILE_SET in CMakeLists.txt, so `cmake --install` never copies it. Any consumer building from source and installing to a prefix (per the README's manual build instructions) gets a fatal "http_endpoint_calculation_mode.h: No such file or directory" error compiling anything that includes tracer_config.h/tracer.h. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracer_config.h(a public header) includeshttp_endpoint_calculation_mode.h, but that file is missing from thepublic_headersFILE_SETlist inCMakeLists.txt.cmake --installnever copieshttp_endpoint_calculation_mode.hto the install prefix'sinclude/datadog/directory, even though the file exists in the source tree.tracer.h/tracer_config.h:FILE_SETlist, alphabetically placed next to the otherhttp_*header.Test plan
FILESlist inCMakeLists.txtagainst the actual contents ofinclude/datadog/in the source tree — this was the only header present in the tree but absent from the list.cmake -B build . && cmake --build build -j && cmake --install build, then compiling a file that includes<datadog/tracer.h>failed with the error above.