Fix README shared-library link flag (-ldd_trace_cpp -> -ldd-trace-cpp)#340
Open
spottsdd wants to merge 1 commit into
Open
Fix README shared-library link flag (-ldd_trace_cpp -> -ldd-trace-cpp)#340spottsdd wants to merge 1 commit into
spottsdd wants to merge 1 commit into
Conversation
…cpp) CMakeLists.txt sets OUTPUT_NAME "dd-trace-cpp" for the shared and static targets, so the installed file is libdd-trace-cpp.so/.a. The README's dynamic linking section still referenced the old -ldd_trace_cpp flag, which doesn't match any installed library name and fails at link time. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🔄 Datadog auto-retried 1 job - 0 passed on retry 🔗 Commit SHA: 7726650 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-ldd_trace_cpp(underscore), butCMakeLists.txtsetsOUTPUT_NAME "dd-trace-cpp"(hyphen) for both the shared and static library targets.libdd-trace-cpp.so/libdd-trace-cpp.a, so following the README's-ldd_trace_cppinstruction as written fails at link time (ld: cannot find -ldd_trace_cpp) /find_librarycan't locate it under that name.-ldd-trace-cpp.Test plan
OUTPUT_NAME "dd-trace-cpp"inCMakeLists.txtand manually confirmedcmake --installproduceslibdd-trace-cpp.soon a fresh build.Made with Cursor