sds-go: add MatchAction UnmarshalJSON - #379
Merged
Merged
Conversation
vinckama
force-pushed
the
vincent.roy/match-action-unmarshal-json
branch
from
August 20, 2026 11:19
e475aec to
de328a3
Compare
MatchAction had MarshalJSON for the Rust-facing rule wire format but no symmetric decoder. Go-marshaled and export-shaped JSON includes both type and match_action inside the object; strict json decoding failed on the inner match_action key and on export placeholders with empty strings. Add UnmarshalJSON with DisallowUnknownFields and tests covering export placeholders, redact variants, unknown-field rejection, and round-trip with MarshalJSON.
vinckama
force-pushed
the
vincent.roy/match-action-unmarshal-json
branch
from
August 20, 2026 12:21
de328a3 to
3015736
Compare
vinckama
changed the base branch from
main
to
vincent.roy/bump-h2-rustsec-2026-0258
August 20, 2026 12:22
fuchsnj
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatchAction had MarshalJSON for the Rust-facing rule wire format but no symmetric decoder. Go-marshaled and export-shaped JSON includes both type and match_action inside the object; strict json decoding failed on the inner match_action key and on export placeholders with empty strings.
Add UnmarshalJSON with DisallowUnknownFields and tests covering export placeholders, redact variants, unknown-field rejection, and round-trip with MarshalJSON.
Needed for this to enforce schema with failing on unknown fields