Skip to content

Remove unused com.github.ben-manes.versions plugin - #3755

Open
0xnm wants to merge 1 commit into
nogorodnikov/rum-18186/migrate-from-buildSrc-to-convention-pluginfrom
nogorodnikov/remove-unused-versions-plugin
Open

Remove unused com.github.ben-manes.versions plugin#3755
0xnm wants to merge 1 commit into
nogorodnikov/rum-18186/migrate-from-buildSrc-to-convention-pluginfrom
nogorodnikov/remove-unused-versions-plugin

Conversation

@0xnm

@0xnm 0xnm commented Aug 21, 2026

Copy link
Copy Markdown
Member

What does this PR do?

We are not actually using this plugin, and Android Studio / Versions Catalog already show new versions anyway. Bumping versions is a granular + manual process in any case.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners August 21, 2026 18:01
@0xnm
0xnm requested review from greghuels and sameerank and removed request for a team August 21, 2026 18:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56138b6b36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread build.gradle.kts
@@ -26,7 +26,6 @@ plugins {
alias(libs.plugins.androidLibraryPlugin) apply false
alias(libs.plugins.kotlinAndroidPlugin) apply false
alias(libs.plugins.dokkaGradlePlugin) apply false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Prefix the commit title with its ticket number

The reviewed commit is titled Remove unused com.github.ben-manes.versions plugin without a ticket identifier, but every commit in this repository must use the RUM-XXXXX: <short description> format and reference its ticket; update the title before merging so the change remains traceable to its issue.

AGENTS.md reference: AGENTS.md:L115-L119

Useful? React with 👍 / 👎.

@datadog-official

datadog-official Bot commented Aug 21, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 70.73% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 56138b6 | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants