Skip to content

Removing flaky test - #3752

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
developfrom
tvaleev/feature/faky-test-removal
Aug 21, 2026
Merged

Removing flaky test#3752
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
developfrom
tvaleev/feature/faky-test-removal

Conversation

@satween

@satween satween commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes JointToStringVsStringBuilderPerformanceTest from dd-sdk-android-core.

Motivation

This test was created in order to verify that in most cases buildString is faster than joinToString and was needed only at development stage. The test is flaky because of uncontrolled initial conditions, it's not guard against changes and basically only verifies the approach correctness.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested a review from jonathanmos August 21, 2026 14:26
@satween
satween marked this pull request as ready for review August 21, 2026 14:26
@satween
satween requested review from a team as code owners August 21, 2026 14:26
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Aug 21, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 71.84% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f44b2fe | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants