RUM-18186: Migrate from buildSrc to convention plugin - #3751
Conversation
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 1 job - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 3182a7c | Docs | View more details | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6a1863518
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
a6a1863 to
3182a7c
Compare
typotter
left a comment
typotter
left a comment
There was a problem hiding this comment.
LGTM for Flags, thanks!
| register("datadogBuildConfig") { | ||
| id = "datadogBuildConfig" // the alias | ||
| implementationClass = "com.datadog.gradle.plugin.config.DatadogBuildConfigPlugin" | ||
| } |
There was a problem hiding this comment.
id is not needed anymore, it takes it from the register call
https://docs.gradle.org/9.4.0/release-notes.html#default-plugin-ids
There was a problem hiding this comment.
Nice! I didn't know about this new thing. We can address it later, remove it for other custom plugins as well.
There was a problem hiding this comment.
👍 , was just an FYI comment, not a blocker
5 participants
What does this PR do?
This PR moves from
buildSrcto Gradle convention plugin to host buildscript logic. As a benefit of this change, we have a better buildscript classpath isolation for different dependencies.Migration is similar to what was done before in DataDog/dd-sdk-android-gradle-plugin#556.
I also spotted JUnit 4 usage for some unit tests and replaced it with JUnit 5.
NOTE: There are some Kotlin buildscript (
.kts) files which were inbuildSrcand left unchanged as a part of this migration. Ideally they need to be converted to the plugin logic as well, but this can be done later, in another PRs.Review checklist (to be filled by reviewers)