RUM-16305: Bump max attribute count limit to 2048 - #3724
RUM-16305: Bump max attribute count limit to 2048#3724aleksandr-gringauz wants to merge 1 commit into
Conversation
The backend's property limit was rolled out to all customers, so the client-side attribute trimming limit needs to match.
ac44675 to
4db2c5a
Compare
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 4db2c5a | Docs | View more details | Give us feedback! |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4db2c5ac49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0xnm
left a comment
There was a problem hiding this comment.
LGTM.
One thing to address though is the way we check the limits: we don't check it for the whole event, but for the individual groups.
For example, in RumEventSerializer we check the limit against context, user and account attributes independently, instead of checking it against context + user + account attributes. Eventually, such approach gives a green light to a situation, when each individual group is below the limit, but sum is above.
I think the root cause is simply historical, because originally attributes validation was created only for Logs which had a single group to validate back at the time https://github.com/DataDog/dd-sdk-android/pull/37/files#diff-04bac6268589e267d1af468f89100891c0609db8412f1512f5fc04469beb23de.
User attributes were added later #420 (and account attributes much later).
I created a ticket RUM-18140 to track this.
What does this PR do?
Bumps
MAX_ATTR_COUNTinDatadogDataConstraintsfrom 128 to 2048.Motivation
The backend's 2048-property limit (tracked under RUM-15843) has been rolled out to all customers. We can adopt it in our SDK as well.
Additional Notes
Review checklist (to be filled by reviewers)