Skip to content

RUM-16305: Bump max attribute count limit to 2048 - #3724

Open
aleksandr-gringauz wants to merge 1 commit into
developfrom
claude/bump-limit-c13843
Open

RUM-16305: Bump max attribute count limit to 2048#3724
aleksandr-gringauz wants to merge 1 commit into
developfrom
claude/bump-limit-c13843

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Bumps MAX_ATTR_COUNT in DatadogDataConstraints from 128 to 2048.

Motivation

The backend's 2048-property limit (tracked under RUM-15843) has been rolled out to all customers. We can adopt it in our SDK as well.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@aleksandr-gringauz aleksandr-gringauz changed the title RUM-17846: Bump max attribute count limit to 2048 RUM-16305: Bump max attribute count limit to 2048 Aug 18, 2026
The backend's property limit was rolled out to all customers, so the
client-side attribute trimming limit needs to match.
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 18, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 71.73% (-0.07%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4db2c5a | Docs | View more details | Give us feedback!

@aleksandr-gringauz

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4db2c5ac49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review August 18, 2026 15:43
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners August 18, 2026 15:43

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One thing to address though is the way we check the limits: we don't check it for the whole event, but for the individual groups.

For example, in RumEventSerializer we check the limit against context, user and account attributes independently, instead of checking it against context + user + account attributes. Eventually, such approach gives a green light to a situation, when each individual group is below the limit, but sum is above.

I think the root cause is simply historical, because originally attributes validation was created only for Logs which had a single group to validate back at the time https://github.com/DataDog/dd-sdk-android/pull/37/files#diff-04bac6268589e267d1af468f89100891c0609db8412f1512f5fc04469beb23de.

User attributes were added later #420 (and account attributes much later).

I created a ticket RUM-18140 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants