PANA-8612: Add snapshot capture orchestration - #3722
Draft
jonathanmos wants to merge 1 commit into
Draft
Conversation
🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 50400d0 | Docs | View more details | Give us feedback! |
jonathanmos
force-pushed
the
jmoskovich/02-sr-new-pipeline
branch
from
August 18, 2026 10:38
001809f to
1ca510f
Compare
Base automatically changed from
jmoskovich/01-sr-new-pipeline
to
feature/sr-new-pipeline
August 18, 2026 12:16
jonathanmos
force-pushed
the
jmoskovich/02-sr-new-pipeline
branch
2 times, most recently
from
August 19, 2026 09:40
99626d9 to
1dd5cfc
Compare
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dd5cfca85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jonathanmos
force-pushed
the
jmoskovich/02-sr-new-pipeline
branch
from
August 19, 2026 10:38
1dd5cfc to
50400d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Second pr for the new pipeline.
Adds the orchestration layer for the composition capture pipeline:
SnapshotCaptureOrchestratorserializes snapshot "generations" end-to-end (traversal, async processing, expiry, handoff), coalescing overlapping capture requests into one follow-up and tracking aCaptureChangesetdescribing what changed (accepted for now, not yet consumed by traversal). Wires this and its supporting pieces (generation/time-budget primitives, Android scheduling and lifecycle glue, the completion queue) intoDefaultRecorderProvider.Also fixes a gap in that wiring:
DefaultRecorderProvidercomputed the heatmap identifier registry unconditionally but only forwarded it to the legacy recorder, so enablingsetHeatmapsEnabled(true)together withsetCompositionTreeRecordingEnabled(true)silently dropped heatmap data with no signal to the caller. It now logs aWARN/Target.USERmessage for that combination, andsetCompositionTreeRecordingEnabled's KDoc documents the incompatibility.Motivation
Continues the new composition-tree capture pipeline (stacked on PANA-8500). The recorder and processing pieces already existed; this PR adds the piece that actually drives a capture end-to-end — deciding when a generation starts, enforcing its time budget, serializing overlapping requests, and handing the result off — while keeping platform callback wiring and the real view-traversal producer out of scope for later workstreams (
CompositionCapturePipeline's producer is still a test seam here). Because there is no traversal implementation yet,compositionTreeRecordingEnabledstays disabled by default and reachable only through the existing@ExperimentalSessionReplayApi; the heatmap warning exists so that gap doesn't surface as a silent feature regression in the meantime.Review checklist (to be filled by reviewers)