Bump SDS to include change to match CamelCase keywords - #945
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the crates/secrets integration to a newer dd-sensitive-data-scanner (SDS) git revision so the static analyzer’s secrets scanning benefits from improved CamelCase proximity-keyword matching behavior described in the PR (e.g., access key matching accessKey, case-insensitive).
Changes:
- Bump the
dd-sensitive-data-scannergitrevused bycrates/secrets. - Refresh
Cargo.lockto reflect the updated git source and resulting transitive dependency resolution changes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/secrets/Cargo.toml | Updates the pinned SDS git revision used by the secrets scanner crate. |
| Cargo.lock | Updates the lockfile to the new SDS git source and associated transitive dependency versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| # remote | ||
| dd-sds = { package = "dd-sensitive-data-scanner", git = "https://github.com/DataDog/dd-sensitive-data-scanner.git", rev = "b2dca51b27a87ecb2d847ad4167a0537afca1972" } | ||
| dd-sds = { package = "dd-sensitive-data-scanner", git = "https://github.com/DataDog/dd-sensitive-data-scanner.git", rev = "dd8be015454dc75307dc6f045a1fba6b21f2b3fc" } |
|
🎯 Code Coverage (details) 🔗 Commit SHA: 2855b49 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
additional dependencies here are from DataDog/dd-sensitive-data-scanner#378
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
datadog-static-analyzerpinsdd-sensitive-data-scannertob2dca51(2026-06-18), which predates DataDog/dd-sensitive-data-scanner#369.Bumping this to include the change of improved matching with camelcase keywords (ie. a rule keyed on
access keynow also matchesaccessKey; not case-sensitive).Also pulling in DataDog/dd-sensitive-data-scanner#378, which is not yet wired to any rule used by
datadog-static-analyzerand should have no impact today (needed only if a rule later opts into it).