Allow paths containing special characters - #22
Open
valeriobelli wants to merge 2 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 424fff83a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
valeriobelli
marked this pull request as draft
July 16, 2026 13:01
valeriobelli
force-pushed
the
handle-special-characters-in-path
branch
from
July 16, 2026 13:15
424fff8 to
8915222
Compare
valeriobelli
marked this pull request as ready for review
July 16, 2026 13:28
valeriobelli
changed the title
valeriobelli
marked this pull request as draft
July 16, 2026 14:32
valeriobelli
marked this pull request as ready for review
July 16, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how shell commands are constructed and invoked to upload dSYM files to Datadog and updates the test suite to match. The main improvement is switching from building shell command strings to passing command arguments as arrays, which avoids issues with paths containing spaces or special characters. The tests have been updated to reflect this change and add coverage for paths containing special characters.