feat(contimage): add hidden bytes and uncompressed image size - #525
Stephanie0829 wants to merge 3 commits into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 451811d2b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Logical regular-file bytes across all layers, including versions hidden by | ||
| // later layers. Same-layer hardlinks count once. Excludes archive and filesystem | ||
| // overhead, symlinks, config and manifest. Absent when collection is unavailable. | ||
| optional uint64 uncompressed_size = 14; |
There was a problem hiding this comment.
This commit and its companion work introduce only the per-layer hidden_bytes metric, but this line also publishes a separate image-level protobuf contract and permanently claims field 14. If merged independently of the total-size work, consumers see an unsupported field and the eventual implementation can no longer choose or revise its wire definition safely; move this field and its generated Go changes to the dedicated uncompressed-size change.
Useful? React with 👍 / 👎.
Stephanie0829
changed the title
1 participant
What does this PR do?
Add optional container-image measurements:
hidden_bytes: logical file data hidden by later deletions or replacements, attributed to the layer that stored it.uncompressed_size: regular-file data across all layers, including hidden versions, counting same-layer hardlinks once. Excludes tar overhead, symlinks, directories, whiteout markers, and image metadata.Absence means unavailable; an explicit zero is a measured zero. No percentage is sent. The existing
sizefield is unchanged.Motivation
Provide comparable logical byte counts for image-optimization analysis. This is not compressed download size, decompressed tar size, or guaranteed reclaimable disk space.
Additional Notes
Companion: datadog-agent #56823, including minikube QA instructions and observed results. Neither draft is ready to merge; user validation is pending.
🤖 Generated with Claude Code