Set DPkg::Lock::Timeout on apt-get calls - #455
Open
colinbjohnson wants to merge 1 commit into
Open
colinbjohnson wants to merge 1 commit into
colinbjohnson wants to merge 1 commit into
Conversation
apt-get fails immediately when another process holds the dpkg lock (e.g. cloud-init or unattended-upgrades on first boot). Acquire::Retries only retries downloads, not lock acquisition. DPkg::Lock::Timeout makes apt wait for the lock; apt versions that predate the option ignore it. Fixes DataDog#449
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
-o DPkg::Lock::Timeout="60"to theapt-get update/apt-get installcalls on the install path.Motivation
Fixes #449.
apt-getfails immediately when another process holds the dpkg lock (cloud-init, unattended-upgrades on first boot).Acquire::Retriesonly retries downloads, not lock acquisition.DPkg::Lock::Timeoutmakes apt wait for the lock; apt versions that predate the option (< 1.9.11) ignore it, so the existing "Could not get lock" retry loop is left in place.Additional Notes
Verified
makeoutput withbash -n.