feat(library): the view count is a chip beside Published - #67
Merged
Merged
Conversation
A count only exists for a published clip, so it sits with the chip that says so: (Published) (eye 37), top right of the card. The metadata line under the title goes back to length, game, date and size, which was one fact too long with the count on the end. The chip is an eye and a number; its accessible name and tooltip carry the words and when it was last opened. Null and zero still draw nothing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65.
The view count moves off the metadata line and into a chip beside Published, top right of the card:
(Published) (eye 37). A count only exists for a published clip, so it belongs with the chip that says so, and the line under the title goes back to length, game, date and size.ClipPublishedBadgedraws the second chip (BaseChip numeric,material-symbols:visibility-outline);ClipMetadatais back to exactly what it was before feat(library): show view count on published clips' cards #65.aria-labelandtitlecarry37 views, last opened 2 days ago.viewCountFigure(the number) besideviewCountLabel(the words), both unit tested to agree.npm run checkgreen, 877 tests. e2e not run.🤖 Generated with Claude Code