fix(security): Stream Deck routes through a switch (alert 17) - #66
Merged
Merged
Conversation
Code scanning still flagged the Map lookup after 3.5.2's typeof guard, because the check and the call sat either side of a promise. A switch leaves nothing for a request to choose. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code scanning alert 17 (
js/unvalidated-dynamic-method-call) stayed open on 3.5.2. Thetypeof route === 'function'guard was on one side ofreadBody(...).then(...)and the call on the other, and CodeQL does not carry the narrowing into the closure. It now points at the call on line 106.This replaces the handler Map with a
Setof known keys (used for the early 404) and aswitchthat calls only the functions it names, so there is no dynamic dispatch left.npm run checkgreennode scripts/streamdeck-check.mjsOK, including the unknown-key 404, tag, publish and the discard locks🤖 Generated with Claude Code