fix(security): check a Stream Deck route is a function before calling it - #62
Merged
Merged
Conversation
Code scanning still reported alert 17 on 3.5.1, at the call rather than the lookup: with a key chosen by the request, it wants the value checked as callable first. The Map from 3.5.1 already limits it to the listed routes; this adds the typeof guard the rule recognises. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert 17 stayed open on 3.5.1: code scanning wants the value checked as callable before a request-chosen route is called. Adds the
typeofguard. Verified: CodeQL on probe PR #61 into main passes with no open alerts.🤖 Generated with Claude Code