fix(security): the three code scanning alerts 3.5.0 raised - #60
Merged
Merged
Conversation
- **Stream Deck routes are looked up as own properties** (alert 17). The key is built from the request, and a bare `ROUTES[key]` also finds what every object inherits. `Object.hasOwn` first. - **A batch log line keeps the clip id out of its format string** (alert 18), where a `%s` would be read as a directive. - Alert 19 is `tagPatternRules.ts` compiling a tag rule the user wrote, which is the feature, and is dismissed as won't fix the same way alert 15 was; that file is the mitigation. `npm run check` 866; `streamdeck-check.mjs` exit 0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
DarrellVS
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups for the three CodeQL alerts raised on main after 3.5.0.
Object.hasOwn).tagPatternRules.tscompiling a user-written tag rule is by design; dismissed as won't fix like [Feature Request]: Retroactive clip compression with Cloudflare cache purge #15, since that file is the mitigation.npm run check866;streamdeck-check.mjspasses.🤖 Generated with Claude Code