fix(streamdeck): crop the discard key's picture square instead of squashing it - #58
Merged
Merged
Conversation
…ashing it The Stream Deck app draws SVG with a renderer that ignores `preserveAspectRatio="xMidYMid slice"`, so the 21:9 thumbnail was squashed into the square key rather than covering it. GoodBit now crops the middle square of the frame and sends it at 144 x 144, so the key's SVG places it one to one and there is nothing left to scale wrongly. Plugin 0.4.2. Checked: the preview route now hands back a 144 x 144 JPEG of the middle of the newest clip, undistorted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stream Deck SVG renderer ignores
slice, so the 21:9 thumbnail was squashed into the square key. GoodBit now crops the centre square and sends it at 144x144. Plugin 0.4.2.Checked: the preview returns a 144x144 undistorted centre crop.
🤖 Generated with Claude Code