fix(storage): hover previews follow the mute setting, like library cards - #53
Merged
Merged
Conversation
The Storage Saver tile's preview was hard-coded `muted`, so a clip could be watched on hover but not heard, which is half of deciding whether a recording is worth keeping. It reads `muteVideosByDefault` now, the same switch a library card reads. Driven: with the setting at its default the hovered preview plays with `muted: false`. `npm run check` 849. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Storage Saver hover preview was hard-coded to muted. It now follows
muteVideosByDefault, like library cards.Driven: with the default setting the hovered preview plays unmuted.
npm run check849.🤖 Generated with Claude Code