fix(storage): watching a clip from Storage Saver is not a view - #50
Merged
Merged
Conversation
Opening a clip records it as opened, and "never opened" is exactly what Storage Saver lists, so looking at a clip there took it off the list the moment it was watched: it could not be deleted from the screen that exists to delete it. `useClipDetail().open` takes `countAsOpen`, and Storage Saver's tiles pass false. The flag is held for as long as the panel is open, so stepping to the next clip inside it does not start counting, and it is put back on close. Every other way of opening a clip counts exactly as before. Driven against a seeded library: a clip opened from Storage Saver stays at openCount 0 and stays on the list; the same clip opened from the library goes to 1. `npm run check` 849. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watching a clip from Storage Saver counted as opening it, so it dropped off "Never opened" straight away and could not be deleted from there.
useClipDetail().opennow takescountAsOpen; Storage Saver passes false, held while the panel is open. Every other entry point counts as before.Driven: opening from Storage Saver leaves openCount at 0 and keeps the clip listed; opening the same clip from the library takes it to 1.
npm run check849.🤖 Generated with Claude Code