feat(storage): watch and scrub before deciding, and never offer a named clip - #49
Merged
Merged
Conversation
…r a named one Two pieces of feedback on Storage Saver. **You could not look at a clip on the one screen that asks you to delete it.** The whole tile was a single button that ticked it, so finding out what a recording held meant leaving the screen and hunting for it in the library, which made the screen pointless. The tile is now two parts: - **The picture is the clip.** Hover plays it and the bottom band scrubs it, from the same `useHoverScrub` and under the same two settings as a library card, one preview at a time. Pressing it opens the clip's own panel, full size, where it plays and can be trimmed or deleted. - **The corner box and the caption are the choice.** They tick it, or in a burst, keep it. Two sibling buttons, not one nested in the other. Closing that panel refreshes the one clip rather than reloading the list. Opening a clip is exactly what "never opened" is about, so a reload would take away the clip you just watched before you could press delete. It goes only if it was deleted from the panel, or given a name or a note. **A clip with its own title is never offered for deletion**, in either section, and neither is one with a note. Naming a clip is the most deliberate thing anyone does with one, and the row with its name is what the Recycle Bin cannot give back. Same rule as the Stream Deck's discard key. Named clips are left out before bursts are worked out, so the unnamed saves around one are still offered as each other's duplicates. Proved against a seeded library: naming one clip and noting another took "Never opened" from 35 to 33 and the bursts from 3 to 2, and clearing both put them back. Driven for real: hover plays one preview, the band scrubs to 0:14, pressing the picture opens the panel, closing it leaves all 38 tiles in place. Gates: `npm run check` 849; `screens.spec.ts` 9 passed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback on Storage Saver, both items.
Watch before deleting. The picture now plays on hover and scrubs along its bottom band (same code and settings as library cards). Pressing it opens the clip panel. The corner box and the caption pick the clip, or keep it in a burst. Closing the panel refreshes only that clip, so watching a clip does not remove it from "Never opened" before you can act on it.
Named clips are never shown, in either section. Clips with notes are not shown either (same rule as the Stream Deck discard key).
Proved: naming one clip and noting another took Never opened 35 to 33 and bursts 3 to 2; clearing both restored them. Driven: hover plays, the scrub band reaches 0:14, the picture opens the panel, closing it keeps all 38 tiles.
Gates:
npm run check849;screens.spec.ts9 passed.🤖 Generated with Claude Code