revert: open the session in the editor from the post-game card (#34) - #44
Merged
Merged
Conversation
Reverts #34 (#19) on request. The overlay card goes back to what it was before: no button, no preload, `setIgnoreMouseEvents(true)` without forwarding, so nothing drawn over a game can take a click. `src/preload/toast.ts`, the route token, `?cut=highlights` in the editor and `scripts/toast-button-check.mjs` go with it. The main preload goes back to `index.mjs` as ESM. `.cjs` was only ever needed because the toast's preload was sandboxed, and that preload is gone. Conflicts resolved in `electron.vite.config.ts` (the pre-#34 single entry) and `CLAUDE.md` (the commands added since #34 are kept). `npm run check`: 689 tests. `npm run build` green. `toast.spec.ts` and `window-state.spec.ts`: 4 passed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 22, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #34 (issue #19), as requested.
setIgnoreMouseEvents(true)without forwarding.src/preload/toast.ts, the route token,?cut=highlightsin the editor,scripts/toast-button-check.mjs, the CLAUDE.md section.index.mjs(ESM). The.cjsoutput only existed for the sandboxed toast preload.electron.vite.config.tstakes the pre-feat(toast): open the session in the editor from the post-game card (#19) #34 single entry;CLAUDE.mdkeeps the commands added after feat(toast): open the session in the editor from the post-game card (#19) #34.Gates:
npm run check689 tests;npm run buildgreen;toast.spec.ts+window-state.spec.ts4 passed.🤖 Generated with Claude Code