Cleaner behavoir for reusing rolls#1135
Open
FalloutFalcon wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Reworks the stuff for roll cooldowns to just silently return the result if it can rather then, returning out if you failed the roll but making you reroll it if you passed, which is a bit odd.
If it doesnt return the old roll it just generically fails instead.
Rolls are also now cleared if they pass the roll cool-down, which should cleanup some odd behavior.
Why It's Good For The Game
better behavoir, should lead to some less weird results
Changelog
🆑
refactor: Tweaks how rolls with cool-down use the old results
/:cl: