Scry the Hearthstone bugfixes and enhancements#1101
Conversation
|
I added comments so that people know these TTRPG mechanics are missing, but in the TTRPG being pinpointed with this power can be resisted with a roll and Obfuscate can be used to evade it. Should I add them or can they be left out? |
|
Also, should I add alerts for when people enter and leave the area you're monitoring? Could be interesting but IDK if it's wanted seeing as they already have thermal vision. |
I dont feel 2 strongly about either tbh.. |
| /datum/discipline_power/visceratika/scry_the_hearthstone/New(datum/discipline/discipline) | ||
| . = ..() | ||
|
|
||
| scry_roll = new() |
There was a problem hiding this comment.
kinda intresting. None of our rolls really do this, i dont really see the reason not to lazy load the datums on the off chance we dont need to waste the effort of making them. Though i have considered standerdizing a "main_roll" datum for powers (gifts and discs) so we can parse out some behavoir like displaying the stats used and such in the button tooltip.
|
|
||
| vitae_cost = 0 | ||
|
|
||
| /datum/discipline_power/visceratika/armor_of_terra/post_gain() |
There was a problem hiding this comment.
oh huh this never got or gets removed if you loose the disc.
| /datum/discipline_power/visceratika/flow_within_the_mountain/can_activate(atom/target, alert) | ||
| . = ..() | ||
| if (!.) | ||
| return. |
There was a problem hiding this comment.
| return. | |
| return . |
| var/distance = get_dist(owner, player) | ||
| var/location_description | ||
| if (distance == 0) | ||
| location_description = "close to you" | ||
| else | ||
| location_description = "[distance] [distance == 1 ? "yard" : "yards"] [dir2text(get_dir(owner, player))]" |
There was a problem hiding this comment.
oh, if we are gonna display it using "yards" then we should make sure to convert it using the defines.
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
3 participants
About The Pull Request
Fixes #927 by making the power use guestbook names instead of mob names as well as a runtime when the power is deactivated and activated within an area. Additionally makes the power give you the direction and distance to players in your area, and adds the TTRPG-accurate restriction that the power can only be used indoors, i.e. within a structure. Also neatens the code up.
Why It's Good For The Game
Bugfixes, makes the power slightly more useful, and makes it more TTRPG-accurate by not letting Gargoyles use it outside of structures.
Changelog
🆑
fix: Scry the Hearthstone now displays guestbook names.
add: Scry the Hearthstone now gives you direction and distance to players in your area, but can no longer be used outdoors.
/:cl: