All disc rolls use applicable stats for better behavoir#1097
Merged
FalloutFalcon merged 10 commits intoJun 17, 2026
Conversation
Contributor
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
chazzyjazzy
reviewed
Jun 10, 2026
chazzyjazzy
reviewed
Jun 10, 2026
chazzyjazzy
reviewed
Jun 10, 2026
chazzyjazzy
approved these changes
Jun 10, 2026
chazzyjazzy
left a comment
chazzyjazzy
left a comment
Contributor
There was a problem hiding this comment.
this is much better than what we've been doing thusfar
…utFalcon/SecondCityF into fix-some-storyteller-rolls
Contributor
|
Fix linters then LGTM @FalloutFalcon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Converts and fully removes the old version of rolling where we pass in a number for passing in a list of stats we want to use and letting the roll use that instead for more logic.
I was making datums for every roll at first but i realized that most of them dont super need the subtypes outside maybe giving them all bumper_text so i just chose not to for rn.
Why It's Good For The Game
All discs will now show what stats your rolling with instead of being hit with a useless number.
Changelog
🆑
qol: All discs should now display what stats they rolled with
fix: scorpions touch poison will properly consider fortitude
refactor: replaces
SSroll.storyteller_rollcompletly withSSroll.storyteller_roll_datum/:cl: