Skip to content

Revert "Circleci project setup" - #94

Merged
Dargon789 merged 1 commit into
mainfrom
revert-43-circleci-project-setup
Feb 2, 2026
Merged

Dargon789 merged 1 commit into
mainfrom
revert-43-circleci-project-setup

Conversation

@Dargon789

@Dargon789 Dargon789 commented Feb 2, 2026 •

Copy link
Copy Markdown
Owner

Reverts #43

Summary by Sourcery

Revert previously added MiniKit and playground features and associated templates and utilities.

Enhancements:

  • Remove MiniKit ready-options test and wallet sign-up configuration from the playground context and provider.

Documentation:

  • Remove the minikit-basic template README from the create-onchain templates.

Tests:

  • Remove tests related to transaction write hooks, crypto utilities, and MiniKit ready options.

Chores:

  • Delete transaction write hooks, crypto utilities, wallet sign-up form component, and Minikit template Farcaster route/layout files from the codebase.

@sourcery-ai

sourcery-ai Bot commented Feb 2, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts the previously added MiniKit playground signup, transaction utilities, and template support by deleting the associated hooks, utilities, tests, templates, and signup-related playground state/UI configuration.

Class diagram for updated AppProvider context state (class diagram)

classDiagram
  class State {
    number chainId
    Record~number,PaymasterConfig~ paymasters
    string nftToken
    boolean isSponsored
    Address vaultAddress
    setChainId(chainId number) void
    setPaymasters(paymasters Record~number,PaymasterConfig~) void
    setNFTToken(nftToken string) void
    setIsSponsored(isSponsored boolean) void
    setVaultAddress(vaultAddress Address) void
  }

  class PaymasterConfig {
    string url
  }

  class AppProvider {
    ReactNode children
    +AppProvider(props ReactNode) void
  }

  class AppContext {
    <<context>>
  }

  class OnchainKitProvider {
    +OnchainKitProvider(config OnchainKitConfig) void
  }

  class OnchainKitConfig {
    number chainId
    string apiKey
    string rpcUrl
    string paymaster
    WalletConfig wallet
  }

  class WalletConfig {
    string display
    string termsUrl
    string privacyUrl
    SupportedWallets supportedWallets
  }

  class SupportedWallets {
    boolean coinbaseSmartWallet
    boolean coinbaseWallet
    boolean embeddedWallet
  }

  AppProvider --> AppContext : provides
  AppProvider --> State : uses
  AppProvider --> OnchainKitProvider : wraps
  OnchainKitProvider --> OnchainKitConfig : configured_by
  OnchainKitConfig --> WalletConfig : has
  WalletConfig --> SupportedWallets : has
  State --> PaymasterConfig : uses

  class RemovedSignupConfig {
    boolean isSignUpEnabled
    setIsSignUpEnabled(isSignUpEnabled boolean) void
    boolean signUpEnabled
  }

  RemovedSignupConfig .. AppProvider : removed_from
  RemovedSignupConfig .. WalletConfig : removed_from
Loading

File-Level Changes

Change Details Files
Remove MiniKit readiness options test from the useMiniKit hook tests.
  • Delete the test that verifies passing ready options through setFrameReady in useMiniKit.
  • Keep remaining MiniKit hook behavior tests intact.
packages/onchainkit/src/minikit/hooks/useMiniKit.test.tsx
Simplify the playground AppProvider context state by removing signup-related configuration.
  • Remove isSignUpEnabled and setIsSignUpEnabled from the AppProvider state type and defaultState.
  • Delete the isSignUpEnabled state persisted via useStateWithStorage and its localStorage key.
  • Drop isSignUpEnabled and its setter from the AppContext value and from the wallet.signupEnabled configuration passed into OnchainKitProvider.
packages/playground/components/AppProvider.tsx
Remove MiniKit-based templates and wallet signup UI introduced by the reverted feature.
  • Delete the minikit-basic template README.
  • Delete the minikit-basic and minikit-snake Farcaster route files and the minikit-snake layout file.
  • Remove the wallet sign-up form component from the playground UI.
packages/create-onchain/templates/minikit-basic/README.md
packages/create-onchain/templates/minikit-basic/app/.well-known/farcaster.json/route.ts
packages/create-onchain/templates/minikit-snake/app/.well-known/farcaster.json/route.ts
packages/create-onchain/templates/minikit-snake/app/layout.tsx
packages/playground/components/form/wallet-sign-up.tsx
Remove transaction write hooks and crypto utilities that supported the reverted MiniKit functionality.
  • Delete the useWriteContracts hook implementation and its tests.
  • Delete the crypto utility module and its tests, which are no longer used after the revert.
packages/onchainkit/src/transaction/hooks/useWriteContracts.ts
packages/onchainkit/src/transaction/hooks/useWriteContracts.test.ts
packages/onchainkit/src/utils/crypto.ts
packages/onchainkit/src/utils/crypto.test.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io

snyk-io Bot commented Feb 2, 2026

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Feb 2, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Repository owner deleted a comment from vercel Bot Feb 2, 2026
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a complete revert of a previous change, specifically PR #43, which was related to 'Circleci project setup'. The revert effectively removes several experimental features and template configurations that were introduced. This includes an experimental Wagmi hook for batching transactions, various MiniKit template files, a UUID generation utility, and a wallet sign-up enablement feature from the playground. The primary objective is to undo these additions, likely to streamline the codebase or remove features that were not ready for integration.

Highlights

  • Revert of Experimental Features: This pull request fully reverts the introduction of the experimental useWriteContracts hook and its associated tests, which was designed for batching transactions with Smart Wallets.
  • MiniKit Template Removal: All files related to the minikit-basic and minikit-snake templates, including their READMEs, Farcaster metadata routes, and layout configurations, have been removed.
  • Utility Function Removal: The generateUUIDWithInsecureFallback utility function and its corresponding tests have been removed from the onchainkit package.
  • Playground Feature Removal: The signUpEnabled feature, its state management within AppProvider, and its dedicated UI component (WalletSignUp) have been removed from the playground application.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the 'Circleci project setup' changes from PR #43. The changes primarily involve removing files and functionality related to MiniKit templates, Farcaster integration, the useWriteContracts hook, and a crypto utility. The modifications in the playground and test files are consistent with these removals. The revert appears clean based on the provided changes.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789
Dargon789 merged commit afa545f into main Feb 2, 2026
11 of 24 checks passed
@Dargon789
Dargon789 deleted the revert-43-circleci-project-setup branch February 2, 2026 05:24
@Dargon789 Dargon789 linked an issue Mar 17, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant