Update cli-minikit.yml

[Dargon789]

b5970f8

What changed? Why?

Notes to reviewers

How has it been tested?

Summary by Sourcery

Resolve merge artifacts in the cli minikit CI workflow and align it with the current minikit app template.

CI:

• Restrict the cli minikit workflow to main branch PRs, removing alpha-specific logic and conditions.
• Fix the CLI invocation used to scaffold the minikit test project and update the test project path to the my-minikit-app template.

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR cleans up the cli-minikit GitHub Actions workflow by resolving merge conflict markers, standardizing it on the minikit variant of the CLI, and updating test project naming to match the minikit app created by the CLI.

Sequence diagram for cli-minikit GitHub Actions workflow on PR

sequenceDiagram
    actor Developer
    participant GitHub
    participant Workflow_cli_minikit as Workflow_cli_minikit
    participant Job_test as Job_test
    participant Step_Run_CLI as Step_Run_CLI
    participant Minikit_CLI as Minikit_CLI
    participant Minikit_App as Minikit_App

    Developer->>GitHub: Open or update pull_request to main
    GitHub->>Workflow_cli_minikit: Trigger cli_build_install_minikit
    Workflow_cli_minikit->>Job_test: Start job on ubuntu_latest
    Job_test->>Job_test: Setup Node.js, checkout repo, install dependencies
    Job_test->>Step_Run_CLI: Execute CLI with --mini option
    Step_Run_CLI->>Minikit_CLI: Run create_onchain CLI with mini flag
    Minikit_CLI-->>Minikit_App: Scaffold my_minikit_app in test_project
    Job_test->>Minikit_App: npm install and build in my_minikit_app
    Minikit_App-->>Job_test: Build succeeds
    Job_test-->>Workflow_cli_minikit: Job completes

Loading

Flow diagram for cli-minikit GitHub Actions workflow structure

flowchart TD
    A[cli_build_install_minikit workflow
on pull_request to main
paths packages/create_onchain] --> B[Test job ubuntu_latest]

    B --> C[Matrix: node_version = 18, 20]
    C --> D[Checkout repository]
    D --> E[Setup Node.js]
    E --> F[Install root dependencies
npm install]
    F --> G[Build CLI package
npm run build in packages/create_onchain]
    G --> H[Create test project directory
mkdir test-project]
    H --> I[Run create_onchain CLI with mini flag
cli.js --mini
piped scripted input]
    I --> J[Install dependencies in
./test-project/my-minikit-app]
    J --> K[Build minikit test app
npm run build]

Loading

File-Level Changes

Change	Details	Files
Resolve merge conflicts and standardize the CLI workflow on the minikit variant, including adjusting the generated app directory name and simplifying branch conditions.	Remove leftover Git merge conflict markers and the alternate onchainkit workflow name in favor of the minikit naming. Restrict pull_request triggers to the main branch only by removing the alpha branch from the workflow configuration. Remove the conditional that skipped the job when the source branch was alpha so the test job always runs. Update the CLI invocation to use the --mini flag and corresponding input sequence consistent with the minikit flow. Rename the test project working directory from my-onchainkit-app to my-minikit-app to align with the app generated by the minikit CLI.	.github/workflows/cli-minikit.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details
actions/actions/checkout	11bd71901bbe5b1630ceea73d27597364c9af683	🟢 6.6	Details Check Score Reason Maintained 🟢 7 9 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 7 Binary-Artifacts 🟢 10 no binaries found in the repo Code-Review 🟢 10 all changesets reviewed Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Token-Permissions ⚠️ 0 detected GitHub workflow tokens with excessive permissions CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Fuzzing ⚠️ 0 project is not fuzzed Packaging ⚠️ -1 packaging workflow not detected Pinned-Dependencies 🟢 3 dependency not pinned by hash detected -- score normalized to 3 License 🟢 10 license file detected Signed-Releases ⚠️ -1 no releases found Security-Policy 🟢 9 security policy file detected Branch-Protection 🟢 5 branch protection is not maximal on development and all release branches Vulnerabilities 🟢 8 2 existing vulnerabilities detected SAST 🟢 8 SAST tool detected but not run on all commits
actions/oven-sh/setup-bun	f4d14e03ff726c06358e5557344e1da148b56cf7	Unknown	Unknown
actions/step-security/harden-runner	002fdce3c6a235733a90a27c80493a3241e56863	🟢 8.5	Details Check Score Reason Binary-Artifacts 🟢 10 no binaries found in the repo Branch-Protection 🟢 8 branch protection is not maximal on development and all release branches CI-Tests 🟢 10 7 out of 7 merged PRs checked by a CI test -- score normalized to 10 CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Code-Review 🟢 10 all changesets reviewed Contributors 🟢 6 project has 2 contributing companies or organizations -- score normalized to 6 Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Dependency-Update-Tool 🟢 10 update tool detected Fuzzing ⚠️ 0 project is not fuzzed License 🟢 10 license file detected Maintained 🟢 10 15 commit(s) and 6 issue activity found in the last 90 days -- score normalized to 10 Packaging ⚠️ -1 packaging workflow not detected Pinned-Dependencies 🟢 6 dependency not pinned by hash detected -- score normalized to 6 SAST 🟢 10 SAST tool is run on all commits Security-Policy 🟢 10 security policy file detected Signed-Releases ⚠️ -1 no releases found Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege Vulnerabilities 🟢 7 3 existing vulnerabilities detected

Scanned Files

• .github/workflows/cli-minikit.yml

[sourcery-ai]

Hey - I've left some high level feedback:

• The workflow no longer triggers on or special-cases the alpha branch; confirm that removing the alpha branch from both on.pull_request.branches and the if: github.head_ref != 'alpha' guard is intentional for your branching strategy.
• The working-directory was updated to ./test-project/my-minikit-app; verify that this matches the actual directory name generated by the --mini CLI path so the install/build steps run in the correct location.
• The scripted CLI input sequence was adjusted for the --mini flag; ensure the sequence still aligns with the current prompts of the create-onchain CLI to avoid the workflow hanging or misconfiguring the test project.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The workflow no longer triggers on or special-cases the `alpha` branch; confirm that removing the `alpha` branch from both `on.pull_request.branches` and the `if: github.head_ref != 'alpha'` guard is intentional for your branching strategy.
- The `working-directory` was updated to `./test-project/my-minikit-app`; verify that this matches the actual directory name generated by the `--mini` CLI path so the install/build steps run in the correct location.
- The scripted CLI input sequence was adjusted for the `--mini` flag; ensure the sequence still aligns with the current prompts of the `create-onchain` CLI to avoid the workflow hanging or misconfiguring the test project.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}