Revert "Update cli-minikit.yml" - #88
Merged
Merged
Conversation
This reverts commit 7333229.
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This comment was marked as abuse.
This comment was marked as abuse.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts the previous change that adapted the workflow from the minikit CLI to the generic onchainkit CLI, restoring the original minikit-focused workflow configuration and conflict markers that need cleanup. Flow diagram for restored minikit CLI test workflow stepsflowchart TD
Start["Start_workflow_on_pull_request"] --> Checkout["Checkout_repository"]
Checkout --> SetupNode["Setup_Node_js_version"]
SetupNode --> InstallRootDeps["Install_root_dependencies_with_npm_install"]
InstallRootDeps --> MkdirTestProject["Create_test_project_directory"]
MkdirTestProject --> RunCliMinikit["Run_create_onchain_cli_with_mini_flag_and_scripted_input"]
RunCliMinikit --> CdGeneratedApp["Change_directory_to_my_onchainkit_app"]
CdGeneratedApp --> InstallAppDeps["Install_app_dependencies_with_npm_install"]
InstallAppDeps --> BuildApp["Build_app_with_npm_run_build"]
BuildApp --> End["End_workflow_job"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The workflow file still contains Git conflict markers (
<<<<<<<<,========,>>>>>>>>); these need to be resolved so that only the intended version of the job name and CLI invocation remains. - Given this is a revert, double-check that the selected workflow name (
cli: build & install ...) and CLI command (--minivs no flag) consistently match the state you want to restore, rather than mixing parts of both branches.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The workflow file still contains Git conflict markers (`<<<<<<<<`, `========`, `>>>>>>>>`); these need to be resolved so that only the intended version of the job name and CLI invocation remains.
- Given this is a revert, double-check that the selected workflow name (`cli: build & install ...`) and CLI command (`--mini` vs no flag) consistently match the state you want to restore, rather than mixing parts of both branches.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #49
Summary by Sourcery
CI: