Skip to content

Revert "Update cli-minikit.yml" - #88

Merged
Dargon789 merged 1 commit into
mainfrom
revert-49-Dargon789-patch-2
Feb 2, 2026
Merged

Dargon789 merged 1 commit into
mainfrom
revert-49-Dargon789-patch-2

Conversation

@Dargon789

@Dargon789 Dargon789 commented Feb 2, 2026 •

Copy link
Copy Markdown
Owner

Reverts #49

Summary by Sourcery

CI:

  • Restore the cli-minikit workflow name and CLI invocation to their prior minikit-specific behavior, effectively reverting the earlier onchainkit changes.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@vercel

This comment was marked as abuse.

@sourcery-ai

sourcery-ai Bot commented Feb 2, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts the previous change that adapted the workflow from the minikit CLI to the generic onchainkit CLI, restoring the original minikit-focused workflow configuration and conflict markers that need cleanup.

Flow diagram for restored minikit CLI test workflow steps

flowchart TD
  Start["Start_workflow_on_pull_request"] --> Checkout["Checkout_repository"]
  Checkout --> SetupNode["Setup_Node_js_version"]
  SetupNode --> InstallRootDeps["Install_root_dependencies_with_npm_install"]
  InstallRootDeps --> MkdirTestProject["Create_test_project_directory"]
  MkdirTestProject --> RunCliMinikit["Run_create_onchain_cli_with_mini_flag_and_scripted_input"]
  RunCliMinikit --> CdGeneratedApp["Change_directory_to_my_onchainkit_app"]
  CdGeneratedApp --> InstallAppDeps["Install_app_dependencies_with_npm_install"]
  InstallAppDeps --> BuildApp["Build_app_with_npm_run_build"]
  BuildApp --> End["End_workflow_job"]
Loading

File-Level Changes

Change Details Files
Restore workflow name and CLI invocation back to the minikit-specific configuration instead of the generic onchainkit version.
  • Change workflow name string back from the onchainkit-oriented label to the minikit label.
  • Update the CLI command pipeline to use the --mini flag and original interactive input sequence instead of the generic onchainkit invocation.
.github/workflows/cli-minikit.yml
Introduce merge conflict markers between the current branch and upstream/main workflow variants that must be resolved.
  • Add Git conflict markers around the workflow name section.
  • Add Git conflict markers around the CLI invocation command block.
.github/workflows/cli-minikit.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io

snyk-io Bot commented Feb 2, 2026

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The workflow file still contains Git conflict markers (<<<<<<<<, ========, >>>>>>>>); these need to be resolved so that only the intended version of the job name and CLI invocation remains.
  • Given this is a revert, double-check that the selected workflow name (cli: build & install ...) and CLI command (--mini vs no flag) consistently match the state you want to restore, rather than mixing parts of both branches.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The workflow file still contains Git conflict markers (`<<<<<<<<`, `========`, `>>>>>>>>`); these need to be resolved so that only the intended version of the job name and CLI invocation remains.
- Given this is a revert, double-check that the selected workflow name (`cli: build & install ...`) and CLI command (`--mini` vs no flag) consistently match the state you want to restore, rather than mixing parts of both branches.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789
Dargon789 merged commit f2c3701 into main Feb 2, 2026
10 of 20 checks passed
@Dargon789
Dargon789 deleted the revert-49-Dargon789-patch-2 branch February 2, 2026 03:27
@Dargon789 Dargon789 linked an issue Mar 17, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vc]: #[Snyk] Security upgrade express from 4.21.2 to 4.22.0#97

1 participant