Skip to content

[Snyk] Security upgrade wagmi from 2.16.3 to 3.0.0 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dargon789 wants to merge 1 commit into from
Closed

[Snyk] Security upgrade wagmi from 2.16.3 to 3.0.0 #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/miniapp-manifest-generator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"react": "19.1.0",
"react-dom": "19.1.0",
"viem": "^2.31.6",
"wagmi": "^2.16.3"
"wagmi": "^3.0.0"

@gemini-code-assist gemini-code-assist Bot Jan 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This major version upgrade of wagmi from v2 to v3 will break the application. The PR metadata itself flags this as a breaking change (isBreakingChange:true). There are two critical issues:

  1. Peer Dependency Conflict: The @coinbase/onchainkit package, which this package depends on, has a peer dependency on wagmi@^2.x. Upgrading wagmi to ^3.0.0 creates a dependency conflict. This is almost certainly why pnpm-lock.yaml failed to update, as mentioned in the PR description.

  2. Breaking API Changes: A major version upgrade implies breaking changes. Code using wagmi APIs, such as the useSignMessage hook in src/hooks/useSignManifest.ts, would need to be refactored to work with wagmi v3. This PR does not include these necessary code updates.

Because of these issues, this change will break the application. I recommend reverting this upgrade. A proper fix would involve finding a version of @coinbase/onchainkit that supports wagmi v3, upgrading both, and refactoring the code that uses them.

Suggested change
"wagmi": "^3.0.0"
"wagmi": "^2.16.3"

},
"devDependencies": {
"@eslint/js": "^9.21.0",
Expand Down
Loading