Update and rename Hardhat.yml to ci-web3-gamefi.yml - #55
Conversation
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames the CircleCI Hardhat pipeline config file to a more general web3 GameFi name and updates an inline comment to point to the correct GitHub project for Docker auth environment variables. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's continuous integration setup by renaming a key CircleCI configuration file. The new name, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In the updated Docker auth comment line, there is an extra leading space before the
#that makes the indentation inconsistent with surrounding lines; consider aligning it to match the other comments in this block.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the updated Docker auth comment line, there is an extra leading space before the `#` that makes the indentation inconsistent with surrounding lines; consider aligning it to match the other comments in this block.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request renames the CircleCI configuration file to better reflect the project's scope and updates a URL within a comment. The changes are clear and align with the stated intent. I have included one minor suggestion to improve code formatting consistency.
* fix: examples/minikit-example/package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-12265451 - https://snyk.io/vuln/SNYK-JS-NEXT-12299318 - https://snyk.io/vuln/SNYK-JS-NEXT-12301496 - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 - https://snyk.io/vuln/SNYK-JS-NEXT-14400644 * Update and rename Hardhat.yml to ci-web3-gamefi.yml (#55) Rename the CircleCI configuration file for the web3 GameFi project and update the referenced CircleCI project URL in the Docker auth comment. CI: Rename the CircleCI config from Hardhat.yml to ci-web3-gamefi.yml to reflect the web3 GameFi project. Update the CircleCI settings URL in the config comment to point to the correct GitHub project for environment variables. Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Delete .circleci/ci-web3-gamefi.yml (#58) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update ci-foundry.yml (#61) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Main (#123) * Revert "Update cli-minikit.yml (#49)" This reverts commit 7333229. * fix: packages/create-onchain/package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-14724253 * Fix React Server Components CVE vulnerabilities Updated dependencies to fix Next.js and React CVE vulnerabilities. The fix-react2shell-next tool automatically updated the following packages to their secure versions: - next - react-server-dom-webpack - react-server-dom-parcel - react-server-dom-turbopack All package.json files have been scanned and vulnerable versions have been patched to the correct fixed versions based on the official React advisory. Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> * chore(deps-dev): bump storybook Bumps the npm_and_yarn group with 1 update in the / directory: [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core). Updates `storybook` from 8.6.7 to 8.6.15 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.6.15/code/core) --- updated-dependencies: - dependency-name: storybook dependency-version: 8.6.15 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> * Delete .circleci directory Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update cli-minikit.yml b5970f8 Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Revert "Circleci project setup (#43)" This reverts commit c5ca6c2. * Update cli-minikit.yml (#95) ai help pin sha 7333229 Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * chore(ONRAMP-843): FundCard accept sessionToken param (coinbase#2501) (#86) (#90) * Add quickAuth example to MiniKit example app (coinbase#2429) * feat: Add Base Account connector support (coinbase#2435) * chore: version packages 🚀 (coinbase#2432) * extended validation to max 8 chars (coinbase#2437) * chore: Use github changesets generator (coinbase#2438) * chore: Manifest validator changeset (coinbase#2440) * chore: Tweak changeset formatter order (coinbase#2442) * feat: Add useSwapToken util (coinbase#2444) * feat: useSendToken hook (coinbase#2445) * fix: Export useSendToken, add example (coinbase#2446) * chore: version packages 🚀 (coinbase#2441) * fix: useFundCardSetupOnrampEventListeners unmount reset (coinbase#2182) * feat: use crypto api for nonce generation (coinbase#2303) * fix: useDebounce cleanup (coinbase#2305) * chore(deps): bump next from 14.2.26 to 14.2.32 (coinbase#2471) * chore(deps-dev): bump vite from 5.4.19 to 5.4.20 (coinbase#2483) * feat: OnchainKit@v1 (coinbase#2415) * chore: Remove deprecated schemaId prop (coinbase#2490) * fix: Remove deprecated cacheTime arg (coinbase#2493) * fix: Fix onchainkit and create-onchain versions (coinbase#2496) * Release create-onchain v1 (coinbase#2497) * chore: version packages 🚀 (coinbase#2498) * chore: Release onchainkit and create-onchain at 1.0.2 (coinbase#2499) * fix: Minikit template prepends process.env.VERCEL_URL with https:// (coinbase#2502) * fix: Add `baseBuilder.allowedAddresses` to template + call `setFrameReady()` automatically (coinbase#2503) * chore: Add changeset to create-onchain (coinbase#2504) * chore: version packages 🚀 (coinbase#2505) * chore(ONRAMP-843): FundCard accept sessionToken param (coinbase#2501) * feat: Allow useOpenUrl to specify fallback behavior (coinbase#2500) * fix: Rename setFrameReady and isFrameReady (coinbase#2510) * fix: Update GetOnrampUrl type (coinbase#2511) * chore: version packages 🚀 (coinbase#2509) * fix: Allow additional properties in `withValidManifest` (coinbase#2515) * chore: version packages 🚀 (coinbase#2516) * fix: Deprecate useNotifications hook (coinbase#2527) * fix: Deprecate Checkout component (coinbase#2528) * fix: Rename allowedAddresses to ownerAddress (coinbase#2530) * chore: version packages 🚀 (coinbase#2529) * chore: fix fund components to mandate session-token (coinbase#2542) * chore: bump react/next due to recent cve (coinbase#2554) e1b37c5 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sohey <soheimam@gmail.com> Co-authored-by: Teimur Gasanov <teymurgg321@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rustam Goygov <139204496+rustam-cb@users.noreply.github.com> Co-authored-by: suryatejamandadi-cb <suryateja.mandadi@coinbase.com> Co-authored-by: Dylan Steck <dylancsteck@gmail.com> * Update issue templates (#87) * Update issue templates * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/custom.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/feature_request.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Potential fix for pull request finding 'CodeQL / Workflow does not contain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Potential fix for pull request finding 'CodeQL / Workflow does not contain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update packages/onchainkit/plugins/__tests__/vite-dual-css.test.ts Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Potential fix for code scanning alert no. 29: Workflow does not contain permissions (#120) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Revert "chore: bump react/next due to recent cve (coinbase#2554)" (#117) This reverts commit e1b37c5. Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sohey <soheimam@gmail.com> Co-authored-by: Teimur Gasanov <teymurgg321@gmail.com> Co-authored-by: Rustam Goygov <139204496+rustam-cb@users.noreply.github.com> Co-authored-by: suryatejamandadi-cb <suryateja.mandadi@coinbase.com> Co-authored-by: Dylan Steck <dylancsteck@gmail.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sohey <soheimam@gmail.com> Co-authored-by: Teimur Gasanov <teymurgg321@gmail.com> Co-authored-by: Rustam Goygov <139204496+rustam-cb@users.noreply.github.com> Co-authored-by: suryatejamandadi-cb <suryateja.mandadi@coinbase.com> Co-authored-by: Dylan Steck <dylancsteck@gmail.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com>
* fix: examples/minikit-example/package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-12265451 - https://snyk.io/vuln/SNYK-JS-NEXT-12299318 - https://snyk.io/vuln/SNYK-JS-NEXT-12301496 - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 - https://snyk.io/vuln/SNYK-JS-NEXT-14400644 * Update and rename Hardhat.yml to ci-web3-gamefi.yml (#55) Rename the CircleCI configuration file for the web3 GameFi project and update the referenced CircleCI project URL in the Docker auth comment. CI: Rename the CircleCI config from Hardhat.yml to ci-web3-gamefi.yml to reflect the web3 GameFi project. Update the CircleCI settings URL in the config comment to point to the correct GitHub project for environment variables. Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Delete .circleci/ci-web3-gamefi.yml (#58) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update ci-foundry.yml (#61) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com> Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com>
* fix: examples/minikit-example/package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-12265451 - https://snyk.io/vuln/SNYK-JS-NEXT-12299318 - https://snyk.io/vuln/SNYK-JS-NEXT-12301496 - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 - https://snyk.io/vuln/SNYK-JS-NEXT-14400644 * Update and rename Hardhat.yml to ci-web3-gamefi.yml (#55) Rename the CircleCI configuration file for the web3 GameFi project and update the referenced CircleCI project URL in the Docker auth comment. CI: Rename the CircleCI config from Hardhat.yml to ci-web3-gamefi.yml to reflect the web3 GameFi project. Update the CircleCI settings URL in the config comment to point to the correct GitHub project for environment variables. Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Delete .circleci/ci-web3-gamefi.yml (#58) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update ci-foundry.yml (#61) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
* fix: examples/minikit-example/package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-12265451 - https://snyk.io/vuln/SNYK-JS-NEXT-12299318 - https://snyk.io/vuln/SNYK-JS-NEXT-12301496 - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 - https://snyk.io/vuln/SNYK-JS-NEXT-14400644 * Update and rename Hardhat.yml to ci-web3-gamefi.yml (#55) Rename the CircleCI configuration file for the web3 GameFi project and update the referenced CircleCI project URL in the Docker auth comment. CI: Rename the CircleCI config from Hardhat.yml to ci-web3-gamefi.yml to reflect the web3 GameFi project. Update the CircleCI settings URL in the config comment to point to the correct GitHub project for environment variables. Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Delete .circleci/ci-web3-gamefi.yml (#58) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update ci-foundry.yml (#61) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com> Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com>
What changed? Why?
Notes to reviewers
How has it been tested?
Summary by Sourcery
Rename the CircleCI configuration file for the web3 GameFi project and update the referenced CircleCI project URL in the Docker auth comment.
CI: