Skip to content

[Snyk] Security upgrade wagmi from 2.14.15 to 3.0.0 - #26

Merged
Dargon789 merged 1 commit into
mainfrom
snyk-fix-59f15c0a4aaff2cd39cabf0e6da4ce35
Nov 30, 2025
Merged

Dargon789 merged 1 commit into
mainfrom
snyk-fix-59f15c0a4aaff2cd39cabf0e6da4ce35

Conversation

@Dargon789

Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.

Snyk changed the following file(s):

  • packages/onchainkit/package.json
⚠️ Warning
Failed to update the pnpm-lock.yaml, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8187303
  786  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@vercel

vercel Bot commented Nov 20, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
my-onchainkit-app Ready Ready Preview Comment Nov 20, 2025 4:57pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
onchainkit-miniapp-manifest-generator Skipped Skipped Nov 20, 2025 4:57pm

@vercel
vercel Bot temporarily deployed to Preview – onchainkit-miniapp-manifest-generator November 20, 2025 16:57 Inactive
@snyk-io

snyk-io Bot commented Nov 20, 2025

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/wagmi ^3.0.0 🟢 8.1
Details
CheckScoreReason
Code-Review🟢 3Found 7/20 approved changesets -- score normalized to 3
Security-Policy🟢 9security policy file detected
Maintained🟢 1030 commit(s) and 5 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Dependency-Update-Tool🟢 10update tool detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 10all dependencies are pinned
License🟢 10license file detected
CII-Best-Practices🟢 5badge detected: Passing
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
SAST🟢 7SAST tool is not run on all commits -- score normalized to 7
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Vulnerabilities🟢 82 existing vulnerabilities detected
CI-Tests🟢 714 out of 20 merged PRs checked by a CI test -- score normalized to 7
Contributors🟢 10project has 30 contributing companies or organizations

Scanned Files

  • packages/onchainkit/package.json

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the security posture of the project by performing a critical dependency upgrade. It updates the 'wagmi' library to its latest major version, '3.0.0', specifically to mitigate a high-severity cryptographic signature vulnerability. While this change significantly improves security, the major version bump necessitates thorough testing to ensure compatibility and prevent any regressions.

Highlights

  • Security Upgrade: This pull request, automatically generated by Snyk, upgrades the 'wagmi' dependency from version '2.14.11' to '3.0.0' to address a critical security vulnerability.
  • Critical Vulnerability Fixed: The upgrade specifically targets and fixes 'SNYK-JS-ELLIPTIC-8187303', an 'Improper Verification of Cryptographic Signature' vulnerability with a score of 786.
  • Major Version Bump: The upgrade to 'wagmi' version '3.0.0' is a major version change, which may introduce breaking changes and requires careful review and testing.
  • Manual Lockfile Update Required: A warning indicates that the 'pnpm-lock.yaml' file failed to update automatically and requires manual intervention before merging.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to resolve a security vulnerability by upgrading wagmi from version 2 to 3. While addressing the vulnerability is important, this is a major version upgrade that introduces significant breaking changes. The current PR only updates the version in package.json and will likely break the build and application functionality. The code needs to be migrated to the new wagmi v3 APIs. Additionally, the pnpm-lock.yaml file has not been updated, as noted in the PR description. I've added a critical comment with more details on the required changes.

Comment thread packages/onchainkit/package.json
@Dargon789 Dargon789 linked an issue Nov 24, 2025 that may be closed by this pull request
@Dargon789
Dargon789 merged commit ca0bbe4 into main Nov 30, 2025
16 of 21 checks passed
@Dargon789
Dargon789 deleted the snyk-fix-59f15c0a4aaff2cd39cabf0e6da4ce35 branch November 30, 2025 20:23

This branch was successfully deployed

1 active and 1 inactive deployments
Preview – my-onchainkit-app — c1c4b6ad Deployed Nov 20, 2025 by vercel[bot]
Preview – onchainkit-miniapp-manifest-generator — c1c4b6ad Deployed Nov 20, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#AutoConnect in MiniKitProvider

2 participants