Skip to content

Coinbase#2529 - #140

Open
Dargon789 wants to merge 3 commits into
mainfrom
coinbase#2529
Open

Dargon789 wants to merge 3 commits into
mainfrom
coinbase#2529

Conversation

@Dargon789

@Dargon789 Dargon789 commented Jul 14, 2026

Copy link
Copy Markdown
Owner

What changed? Why?

Notes to reviewers

How has it been tested?

Summary by Sourcery

Tighten FundButton funding-source typing and add repository security and automation workflows.

Bug Fixes:

  • Make FundButton props enforce exactly one funding source at the type level.

Build:

  • Add CircleCI configuration templates for project automation.

CI:

  • Add GitHub Actions for dependency review and stale issue or pull request management.

Documentation:

  • Add a security policy covering supported versions and vulnerability reporting.

Dargon789 and others added 2 commits July 14, 2026 13:26
* chore: version packages 🚀 (coinbase#2529)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: fix fund components to mandate session-token (coinbase#2542)

* chore: bump react/next due to recent cve (coinbase#2554)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: suryatejamandadi-cb <suryateja.mandadi@coinbase.com>
Co-authored-by: Dylan Steck <dylancsteck@gmail.com>
@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
my-onchainkit-app Ready Ready Preview Sep 15, 2026 6:21am UTC
onchainkit-miniapp-manifest-generator Error Error Sep 15, 2026 6:21am UTC
onchainkit-minikit-example Ready Ready Preview Sep 15, 2026 6:21am UTC

@sourcery-ai

sourcery-ai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR adds basic security, automation, and documentation infrastructure: GitHub workflows for dependency vulnerability review and stale issue/PR management, initial CircleCI pipeline configurations, and a template SECURITY.md policy file.

Sequence diagram for dependency review GitHub Action on pull requests

sequenceDiagram
  actor Developer
  participant GitHub
  participant dependency_review_workflow
  participant actions_dependency_review_action
  participant PullRequest

  Developer->>GitHub: open_pull_request
  GitHub->>dependency_review_workflow: pull_request_event_main
  dependency_review_workflow->>actions_dependency_review_action: run_dependency-review-action
  actions_dependency_review_action->>PullRequest: comment-summary-in-pr
  alt [vulnerable_dependencies_found]
    GitHub->>PullRequest: mark_check_run_failed
  else [no_vulnerabilities]
    GitHub->>PullRequest: mark_check_run_success
  end
Loading

Sequence diagram for stale issues and pull requests GitHub Action

sequenceDiagram
  participant GitHub
  participant stale_workflow
  participant actions_stale
  participant Issue
  participant PullRequest

  GitHub->>stale_workflow: schedule_cron_29_4_daily
  stale_workflow->>actions_stale: run_actions-stale@v5
  actions_stale->>Issue: add_stale-issue-message
  actions_stale->>Issue: add_no-issue-activity_label
  actions_stale->>PullRequest: add_stale-pr-message
  actions_stale->>PullRequest: add_no-pr-activity_label
Loading

File-Level Changes

Change Details Files
Introduce GitHub dependency review workflow for pull requests targeting main.
  • Add dependency-review workflow triggered on pull_request events to main
  • Configure minimal read permissions for contents and write permissions for pull requests
  • Run actions/checkout followed by actions/dependency-review-action with comment-summary-in-pr enabled and example commented configuration options
.github/workflows/dependency-review.yml
Add starter CircleCI configuration with a simple hello-world job and workflow.
  • Define say-hello job using cimg/base:current Docker image
  • Configure job steps to checkout code and run a Hello, World command
  • Create say-hello-workflow that runs the say-hello job
.circleci/config.yml
Add GitHub workflow to mark inactive issues and pull requests as stale and label them accordingly.
  • Schedule workflow via daily cron
  • Grant write permissions to issues and pull requests
  • Configure actions/stale to post stale messages and apply no-issue-activity and no-pr-activity labels
.github/workflows/stale.yml
Introduce CircleCI configuration for a custom executor and placeholder Hardhat-related job and workflow.
  • Define my-custom-executor using cimg/base:stable Docker image with Docker Hub auth via environment variables
  • Add web3-defi-game-project- job using the custom executor with checkout and placeholder run step
  • Create my-custom-workflow to run the web3-defi-game-project- job
.circleci/Hardhat.yml
Add SECURITY.md template describing supported versions and vulnerability reporting guidance placeholder.
  • Document supported versions in a table with checkmark/cross indicators
  • Add section for reporting vulnerabilities with instructions to be filled in later
SECURITY.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io

snyk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

Snyk checks have failed. 16 issues have been found so far.

Status Scan Engine Critical High Medium Low Total (16)
Open Source Security 4 6 4 2 16 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The two new CircleCI configs (config.yml and Hardhat.yml) currently contain placeholder jobs (e.g., say-hello, commented out run step, oddly named web3-defi-game-project- job) that don’t do any meaningful work; consider either fleshing these out into real pipelines or removing them to avoid confusing or noisy CI configuration.
  • In .github/workflows/dependency-review.yml, you’re granting pull-requests: write solely to support comment-summary-in-pr; if you don’t strictly need automated comments, you could disable that option and drop the write permission to keep the workflow’s token scope minimal.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The two new CircleCI configs (`config.yml` and `Hardhat.yml`) currently contain placeholder jobs (e.g., `say-hello`, commented out run step, oddly named `web3-defi-game-project-` job) that don’t do any meaningful work; consider either fleshing these out into real pipelines or removing them to avoid confusing or noisy CI configuration.
- In `.github/workflows/dependency-review.yml`, you’re granting `pull-requests: write` solely to support `comment-summary-in-pr`; if you don’t strictly need automated comments, you could disable that option and drop the write permission to keep the workflow’s token scope minimal.

Fix all in Cursor


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the FundButton and FundCard components to enforce funding source requirements, making sessionToken a required prop for FundCard and requiring either fundingUrl or sessionToken for FundButton. It also updates the associated tests, types, and demo playground, alongside upgrading the next dependency to version 15.3.6. The review feedback recommends refining the TypeScript union types for FundButtonSourceProps to strictly enforce mutual exclusivity of fundingUrl and sessionToken using never, and adding a corresponding runtime check in FundButton to prevent both props from being provided simultaneously.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/onchainkit/src/fund/types.ts Outdated
Comment thread packages/onchainkit/src/fund/components/FundButton.tsx
@github-actions

Copy link
Copy Markdown

Stale pull request message

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequence diagram for dependency review GitHub Action on pull requests

2 participants