Coinbase#2529 - #140
Coinbase#2529#140Dargon789 wants to merge 3 commits into
Conversation
* chore: version packages 🚀 (coinbase#2529) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: fix fund components to mandate session-token (coinbase#2542) * chore: bump react/next due to recent cve (coinbase#2554) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: suryatejamandadi-cb <suryateja.mandadi@coinbase.com> Co-authored-by: Dylan Steck <dylancsteck@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideThis PR adds basic security, automation, and documentation infrastructure: GitHub workflows for dependency vulnerability review and stale issue/PR management, initial CircleCI pipeline configurations, and a template SECURITY.md policy file. Sequence diagram for dependency review GitHub Action on pull requestssequenceDiagram
actor Developer
participant GitHub
participant dependency_review_workflow
participant actions_dependency_review_action
participant PullRequest
Developer->>GitHub: open_pull_request
GitHub->>dependency_review_workflow: pull_request_event_main
dependency_review_workflow->>actions_dependency_review_action: run_dependency-review-action
actions_dependency_review_action->>PullRequest: comment-summary-in-pr
alt [vulnerable_dependencies_found]
GitHub->>PullRequest: mark_check_run_failed
else [no_vulnerabilities]
GitHub->>PullRequest: mark_check_run_success
end
Sequence diagram for stale issues and pull requests GitHub ActionsequenceDiagram
participant GitHub
participant stale_workflow
participant actions_stale
participant Issue
participant PullRequest
GitHub->>stale_workflow: schedule_cron_29_4_daily
stale_workflow->>actions_stale: run_actions-stale@v5
actions_stale->>Issue: add_stale-issue-message
actions_stale->>Issue: add_no-issue-activity_label
actions_stale->>PullRequest: add_stale-pr-message
actions_stale->>PullRequest: add_no-pr-activity_label
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
⛔ Snyk checks have failed. 16 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The two new CircleCI configs (
config.ymlandHardhat.yml) currently contain placeholder jobs (e.g.,say-hello, commented out run step, oddly namedweb3-defi-game-project-job) that don’t do any meaningful work; consider either fleshing these out into real pipelines or removing them to avoid confusing or noisy CI configuration. - In
.github/workflows/dependency-review.yml, you’re grantingpull-requests: writesolely to supportcomment-summary-in-pr; if you don’t strictly need automated comments, you could disable that option and drop the write permission to keep the workflow’s token scope minimal.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The two new CircleCI configs (`config.yml` and `Hardhat.yml`) currently contain placeholder jobs (e.g., `say-hello`, commented out run step, oddly named `web3-defi-game-project-` job) that don’t do any meaningful work; consider either fleshing these out into real pipelines or removing them to avoid confusing or noisy CI configuration.
- In `.github/workflows/dependency-review.yml`, you’re granting `pull-requests: write` solely to support `comment-summary-in-pr`; if you don’t strictly need automated comments, you could disable that option and drop the write permission to keep the workflow’s token scope minimal.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request updates the FundButton and FundCard components to enforce funding source requirements, making sessionToken a required prop for FundCard and requiring either fundingUrl or sessionToken for FundButton. It also updates the associated tests, types, and demo playground, alongside upgrading the next dependency to version 15.3.6. The review feedback recommends refining the TypeScript union types for FundButtonSourceProps to strictly enforce mutual exclusivity of fundingUrl and sessionToken using never, and adding a corresponding runtime check in FundButton to prevent both props from being provided simultaneously.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Stale pull request message |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
What changed? Why?
Notes to reviewers
How has it been tested?
Summary by Sourcery
Tighten FundButton funding-source typing and add repository security and automation workflows.
Bug Fixes:
Build:
CI:
Documentation: