Potential fix for code scanning alert no. 17: Incomplete string escaping or encoding

[Dargon789]

Potential fix for https://github.com/Dargon789/mempool/security/code-scanning/17

Use a global replacement so all & characters are handled consistently.

Best minimal fix (no behavior change beyond correcting the bug): in frontend/src/app/lightning/nodes-per-isp-chart/nodes-per-isp-chart.component.ts, update line 144 from string-based replace to regex-based global replace:

• From: isp[1].replace('&', '')
• To: isp[1].replace(/&/g, '')

No new imports, methods, or dependencies are required.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by Sourcery

Bug Fixes:

• Fix incomplete removal of ampersand characters in ISP labels by applying the replacement globally.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
mempool	Ready	Preview, Comment	Jun 1, 2026 11:44pm

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces a single-occurrence string replace with a global regex replace to correctly remove all '&' characters from ISP names when building chart labels, addressing an incomplete escaping/encoding issue without altering other behavior.

File-Level Changes

Change	Details	Files
Ensure all '&' characters are stripped from ISP names when constructing chart labels.	Changed string-based replace call to a regex-based global replace so multiple '&' characters are removed, not just the first occurrence Kept the rest of the label construction logic (mobile/widget checks and percentage suffix) unchanged to avoid behavioral regressions	frontend/src/app/lightning/nodes-per-isp-chart/nodes-per-isp-chart.component.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[gemini-code-assist]

Code Review

This pull request updates the ISP name formatting in the nodes-per-isp-chart component to replace all occurrences of the ampersand character using a global regular expression. The reviewer suggests adding a fallback or optional chaining to prevent potential runtime errors if the ISP name is null or undefined.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.