updated demo redirect handling

[Dargon789]

Summary by Sourcery

Improve demo redirect URL handling and update asset sync script while adding a basic CircleCI workflow configuration.

Enhancements:

• Encode the next demo path parameter when constructing redirect URLs for demo routing.
• Simplify liquid asset download path handling in the asset sync script.

CI:

• Introduce a minimal CircleCI configuration with a custom executor and placeholder web3-related job.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
mempool	Ready	Preview, Comment	May 11, 2026 6:57am

[sourcery-ai]

Reviewer's Guide

Updates demo redirect URL construction to use the current path and URL-encoded next path, simplifies liquid asset filename handling in the asset sync script, and introduces a basic CircleCI config for a web3/defi/game-related workflow.

Sequence diagram for updated demo redirect handling

sequenceDiagram
  actor User
  participant Browser
  participant AngularRouter
  participant handleDemoRedirect

  User->>Browser: Navigate to demo URL with next param
  Browser->>AngularRouter: Activate route with query params
  AngularRouter->>handleDemoRedirect: Call with route and router
  handleDemoRedirect->>AngularRouter: Read query param next
  handleDemoRedirect->>handleDemoRedirect: Find index in path array
  alt next matches known path
    handleDemoRedirect->>handleDemoRedirect: Set currentPath
    handleDemoRedirect->>handleDemoRedirect: Compute nextPath
    handleDemoRedirect->>handleDemoRedirect: Build redirectUrl with encodeURIComponent
    handleDemoRedirect-->>Browser: Schedule setTimeout 15000ms
    Browser-->>Browser: Wait 15000ms
    Browser->>Browser: window.location.replace redirectUrl
  else next not in path
    handleDemoRedirect-->>AngularRouter: No redirect scheduled
  end

Loading

Flow diagram for simplified Liquid asset sync file handling

graph TD
  A[Start_downloadLiquidAssets] --> B[Log Downloading assets]
  B --> C[Iterate_liquidAssets]
  C --> D[Extract file and url]
  D --> E[Set fileName_to_file]
  E --> F[Log Downloading fileName]
  F --> G[downloadFile with ASSETS_PATH_slash_fileName and url]
  G --> H[Next_asset_or_end]
  H -->|More_assets| C
  H -->|No_more_assets| I[End_downloadLiquidAssets]

Loading

File-Level Changes

Change	Details	Files
Improve demo redirect URL construction and safety in common Angular utility.	Derive the current demo path from the existing path array using the computed index. Compute the next path from the same array and URL-encode it before embedding in the query string. Build the redirect URL using the current path and encoded next path and reuse it in the setTimeout callback instead of interpolating directly from params.	frontend/src/app/shared/common.utils.ts
Simplify Liquid asset filename derivation in the sync-assets script.	Remove the redundant replace() call when computing fileName for Liquid assets. Use the file field directly as the target filename for downloadFile calls.	frontend/sync-assets.js
Add a minimal CircleCI workflow configuration using a custom executor.	Define a reusable Docker-based executor with authenticated access to Docker Hub using environment variables. Add a placeholder job that checks out the repo and logs the working directory. Wire the job into a simple workflow named my-custom-workflow so it runs on the pipeline.	.circleci/web3_defi_gamefi.yml

Possibly linked issues

• Fix demo redirect logic and introduce a suite of CI/CD configurations #41: PR implements the corrected demo redirect logic described in the issue and adds related CircleCI configuration.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
🔚	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Code Review

This pull request introduces a new CircleCI configuration, refactors asset synchronization, and updates the demo redirect utility. Feedback includes correcting the CircleCI filename and job naming, updating repository references, and improving asynchronous handling in the asset download script. Additionally, it is recommended to use the Angular Router for redirects instead of a full page reload to maintain SPA behavior.

I am having trouble creating individual review comments. Click here to see my feedback.

.circleci/web3_defi_gamefi.yml (1)

CircleCI requires the primary configuration file to be named config.yml and located in the .circleci directory. A file named web3_defi_gamefi.yml will not be recognized by CircleCI unless dynamic configuration is explicitly enabled for this repository.

frontend/sync-assets.js (343-347)

The downloadLiquidAssets function uses forEach to trigger asynchronous downloadFile calls without awaiting them. Since the main execution block also does not await downloadLiquidAssets(), the Node.js process could exit before these downloads are finished, potentially resulting in incomplete or corrupted files. Using Promise.all() with map() ensures that these background tasks are properly tracked. Additionally, the fileName variable is redundant and can be removed.

  return Promise.all(liquidAssets.map(({ file, url }) => {
    console.log(`${LOG_TAG} Downloading ${file}`);
    return downloadFile(`${ASSETS_PATH}/${file}`, url);
  }));

.circleci/web3_defi_gamefi.yml (11)

The URL in this comment refers to a specific user's fork (Dargon789/foundry) rather than the main repository. This suggests the configuration was copied from an external source and should be updated to reflect the current project's context.

.circleci/web3_defi_gamefi.yml (15)

The job name web3-defi-game-project- ends with a trailing hyphen, which appears to be a typo or an incomplete identifier. It is recommended to use a cleaner name.

frontend/src/app/shared/common.utils.ts (235)

In an Angular application, using window.location.replace() triggers a full page reload, which is inefficient as it destroys and re-initializes the application state. Since the Router is already provided as an argument to this function, it is recommended to use router.navigateByUrl() with replaceUrl: true to maintain the Single Page Application (SPA) behavior.

          setTimeout(() => { router.navigateByUrl(redirectUrl, { replaceUrl: true }); }, 15000);

[sourcery-ai]

Hey - I've left some high level feedback:

• In handleDemoRedirect, consider normalizing params.next (e.g., stripping trailing slashes or query strings) before the indexOf lookup so the redirect logic is more robust to minor variations in the path.
• The new .circleci/web3_defi_gamefi.yml config appears to be a standalone placeholder with project-specific comments and secrets; it may be clearer either to integrate this into the main CircleCI config (or a reusable orb) or relocate it under an examples/ci directory to avoid confusion in the primary CI setup.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In handleDemoRedirect, consider normalizing `params.next` (e.g., stripping trailing slashes or query strings) before the `indexOf` lookup so the redirect logic is more robust to minor variations in the path.
- The new `.circleci/web3_defi_gamefi.yml` config appears to be a standalone placeholder with project-specific comments and secrets; it may be clearer either to integrate this into the main CircleCI config (or a reusable orb) or relocate it under an examples/ci directory to avoid confusion in the primary CI setup.

Fix all in Cursor

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}