Fix the release artifact: .nupkgs is hidden, so it uploaded nothing - #223
Merged
Conversation
The first dry run of release.yml went green while quietly producing no artifact:
##[warning]No files were found with the provided path: .nupkgs/*.nupkg.
No artifacts will be uploaded.
The packages were built and collected correctly - the log shows
Dapper.AOT.1.1.0.nupkg and Dapper.Advisor.1.1.0.nupkg - but
actions/upload-artifact excludes hidden files by default, and `.nupkgs` is a
dot-directory, so the upload matched nothing and only warned. That would have cost
us the "packages survive a failed push" guarantee precisely when it mattered.
Dropped the dot rather than setting include-hidden-files, so it does not depend on
an action input that could change again, and left a note so nobody tidies it back.
versionHeightOffset -3 -> -4, because this is another commit on main and the target
is still 1.1.0; simulated the squash to confirm (height 4, build 0, 1.1.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first dry run of
release.ymlwent green while quietly producing no artifact:The packages themselves were fine — the log shows
Dapper.AOT.1.1.0.nupkgandDapper.Advisor.1.1.0.nupkgbuilt and collected, at the right version. Butactions/upload-artifactexcludes hidden files by default, and.nupkgsis a dot-directory, so the upload matched nothing and merely warned.That matters because the artifact is the "packages survive a failed push" guarantee — it would have been missing at exactly the moment it was needed, and the run would still have been green.
Dropped the dot rather than setting
include-hidden-files: true, so it doesn't depend on an action input whose default could shift again, and left a comment so nobody tidies it back.Version
versionHeightOffset-3→-4: this is another commit on main and the target is still 1.1.0. Simulated the squash rather than assuming —{'VersionHeight': 4, 'BuildNumber': 0, 'NuGetPackageVersion': '1.1.0'}.Worth noting about the dry run
This is the value of running it before tagging: a workflow that had never executed went green on its first outing and was still wrong. Once this merges, a second dispatch run should be checked for the artifact actually appearing on the run — not just for a green tick.