feat(databricks): add authenticated workspace client boundary - #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a small Databricks platform-access boundary that constructs an initialized official
WorkspaceClientwithout moving authentication concerns into the observation domain or reimplementing Databricks authentication policy.Changes
semapact.platforms.databricks.create_databricks_workspace_client(...);workspace_url,token, andprofilehints;WorkspaceClientconstructor;WorkspaceClient()and the Databricks SDK default/unified authentication chain;auth_typeor impose PAT-specific host/token pairing;databricks-sdk, keeping base SemaPact independent from the Databricks optional extra;semapact.observationunchanged: platform operations still consume an already initialized client;semapact[databricks]CI smoke offline by validating the official SDK constructor API rather than initializing credentials in CI;Boundary
Examples:
The factory itself does not read environment variables. When explicit hints are omitted, the Databricks SDK may resolve its standard environment/configuration, including Azure/Entra/OAuth/service-principal/managed-identity flows supported by the SDK.
Out of scope
Validation
WorkspaceClient(**{})call;semapact[databricks]CI installs the real SDK, verifies theWorkspaceClientconstructor supportshost,token, andprofile, and runs both client-boundary and observation tests without making a live Databricks request.