revert: remove seqlock/versioning read path - #14
Merged
Conversation
Reverts the seqlock-based lock-free read path and version counter introduced in cb8886f. Reads now always go through the CAS lock path. Keeps unrelated improvements from the same commit: - do_write helper for better codegen on inserts - make_entry tuple refactor in insert_inner - let Ok(v) pattern replacing .unwrap() - All new tests (renamed from seqlock to copy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the seqlock-based lock-free read path and version counter introduced in cb8886f. Reads now always go through the CAS lock path.
Keeps unrelated improvements from the same commit:
do_writehelper for better codegen on insertsmake_entrytuple refactor ininsert_innerlet Ok(v)pattern replacing.unwrap()