Fixes: #161 - Use correct display_attrs on SupportSKUIndex and SupportContractIndex#163
Open
natecohen wants to merge 1 commit into
Open
Fixes: #161 - Use correct display_attrs on SupportSKUIndex and SupportContractIndex#163natecohen wants to merge 1 commit into
display_attrs on SupportSKUIndex and SupportContractIndex#163natecohen wants to merge 1 commit into
Conversation
Updated SupportSKUIndex and SupportContractIndex and add test cases
DanSheps
requested changes
Jul 7, 2026
| SupportSKUIndex.display_attrs should only reference | ||
| fields that exist on the SupportSKU model. | ||
| """ | ||
| index = SupportSKUIndex() |
| SupportContractIndex.display_attrs should only reference | ||
| fields that exist on the SupportContract model. | ||
| """ | ||
| index = SupportContractIndex() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #161 - Use correct
display_attrsonSupportSKUIndexandSupportContractIndexSearches matching SupportSKU or SupportContract cause
FieldDoesNotExisterrors.This PR corrects the values and adds a test case to
tests_search.py.