Add a README screenshot, captured from the running editor - #30
Draft
DanKane2029 wants to merge 1 commit into
Draft
DanKane2029 wants to merge 1 commit into
DanKane2029 wants to merge 1 commit into
Conversation
A renderer's README needs a picture. Adds one: the editor with the snowman's head selected, showing the selection outline, the translate gizmo, and the Objects and Inspector panels populated. It is generated by scripts/screenshots.mjs rather than hand-captured, following the same pattern word-up uses, so it cannot drift into showing something the app no longer does. Headless Chromium has no WebGL2 context without SwiftShader, so the script launches it with the matching ANGLE flags and waits for the software rasterizer to settle before capturing. Also brings the README up to date with what landed in #27 and #28 - the Render panel, camera entities, and the test count - and syncs package-lock's stale 'web-template'/ISC metadata to match package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29: the README shipped without an image. A renderer's README needs a picture.
Generated, not hand-captured
scripts/screenshots.mjs(new,npm run screenshots) drives the real editor and captures it, following the same pattern word-up already uses — so the image can't drift into showing something the app no longer does. Headless Chromium has no WebGL2 context at all without SwiftShader, so the script passes the matching ANGLE flags and waits for the software rasterizer to land a few frames before the shutter.Also brings the README up to date with #27/#28
Both merged after #29 was written, and made parts of it stale:
package-lock.json's staleweb-template/ISC metadata synced topackage.json.Two things I found but did not fix
The rotate gizmo's Y ring renders black, not green.
handleMaterialsinsrc/Renderer/Gizmo.tsbuilds the handles withlitProgram. The Y ring lies flat in the XZ plane, so its normals point straight up and it catches almost no diffuse from the light rig — it comes out black next to a red and a blue ring. Gizmo handles want constant colour regardless of orientation, which is whatunlitProgramis for (Outline.tsalready uses it). I left it alone because a renderer change doesn't belong in a docs PR, but it's why there's no rotate-mode screenshot here.spawnDragonandspawnBunnyare now unreachable from the UI. Dropping the 1/2/3 hotkeys in #27 removed the only entry point; they're live only from tests. The dragon scene made a considerably better screenshot than the snowman — if you restore a way to load it (File ▸ New from template, say), re-runningnpm run screenshotswill pick it up.Targeted at
maindirectly, per CLAUDE.md.